depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags #21869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Suggested by @guidovranken in google/oss-fuzz#5713 (comment). Thanks! |
Member
|
Concept ACK. https://libcxx.llvm.org/docs/DesignDocs/DebugMode.html. |
Contributor
|
cr ACK fa9249a: patch looks correct |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 9, 2021
…flags fa9249a depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags (MarcoFalke) Pull request description: Commands that can be used for testing: ``` $ cat 1.cpp #include <vector> int main() { std::vector<int> foo; foo.begin() + 7; } ``` ``` clang++ -stdlib=libc++ -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe g++ -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe ACKs for top commit: practicalswift: cr ACK fa9249a: patch looks correct fanquake: ACK fa9249a - was going to suggest adding this to the macOS CPP flags as well, however it seems doing that is less straight forward. Could be looked at by someone in a followup. Tree-SHA512: 2ffbaaf0ccb36bcc9fa1a15426566406c6115c8878ff211a4794d982c5d198672d444a20f6c7ae9f341193f6d8118c7cc50896daf98af9553834379e47ddb39e
fanquake
added a commit
that referenced
this pull request
May 26, 2021
fa0bfc5 ci: Bump multiprocess memory (MarcoFalke) Pull request description: Fixes #22059 ACKs for top commit: ryanofsky: Code review ACK fa0bfc5. Thanks for the update, and interesting to know about #21869. It looks like relevant build https://cirrus-ci.com/task/4807455453478912 is succeeding too fanquake: ACK fa0bfc5 Tree-SHA512: f6e49aadf33199ffa7960c8da0b81bdc5ffea61f373e1b0367d000cdbd214614374b9f1a8b3ce9b8270e6d13a24a2029ab07bddb48e44c86dcb687d645e5ef34
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 27, 2021
fa0bfc5 ci: Bump multiprocess memory (MarcoFalke) Pull request description: Fixes bitcoin#22059 ACKs for top commit: ryanofsky: Code review ACK fa0bfc5. Thanks for the update, and interesting to know about bitcoin#21869. It looks like relevant build https://cirrus-ci.com/task/4807455453478912 is succeeding too fanquake: ACK fa0bfc5 Tree-SHA512: f6e49aadf33199ffa7960c8da0b81bdc5ffea61f373e1b0367d000cdbd214614374b9f1a8b3ce9b8270e6d13a24a2029ab07bddb48e44c86dcb687d645e5ef34
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…flags fa9249a depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags (MarcoFalke) Pull request description: Commands that can be used for testing: ``` $ cat 1.cpp #include <vector> int main() { std::vector<int> foo; foo.begin() + 7; } ``` ``` clang++ -stdlib=libc++ -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe g++ -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe ACKs for top commit: practicalswift: cr ACK fa9249a: patch looks correct fanquake: ACK fa9249a - was going to suggest adding this to the macOS CPP flags as well, however it seems doing that is less straight forward. Could be looked at by someone in a followup. Tree-SHA512: 2ffbaaf0ccb36bcc9fa1a15426566406c6115c8878ff211a4794d982c5d198672d444a20f6c7ae9f341193f6d8118c7cc50896daf98af9553834379e47ddb39e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
…flags fa9249a depends: Add missing -D_LIBCPP_DEBUG=1 to debug flags (MarcoFalke) Pull request description: Commands that can be used for testing: ``` $ cat 1.cpp #include <vector> int main() { std::vector<int> foo; foo.begin() + 7; } ``` ``` clang++ -stdlib=libc++ -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe g++ -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC -D_LIBCPP_DEBUG=1 -Wall 1.cpp -o exe && ./exe ACKs for top commit: practicalswift: cr ACK fa9249a: patch looks correct fanquake: ACK fa9249a - was going to suggest adding this to the macOS CPP flags as well, however it seems doing that is less straight forward. Could be looked at by someone in a followup. Tree-SHA512: 2ffbaaf0ccb36bcc9fa1a15426566406c6115c8878ff211a4794d982c5d198672d444a20f6c7ae9f341193f6d8118c7cc50896daf98af9553834379e47ddb39e
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands that can be used for testing: