Skip to content

ci: Enable D_GLIBCXX_DEBUG for multiprocess task #21812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 3 commits into from
May 4, 2021
Merged

ci: Enable D_GLIBCXX_DEBUG for multiprocess task #21812

fanquake merged 3 commits into from
May 4, 2021

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Apr 30, 2021

Enable -D_GLIBCXX_DEBUG via the depends DEBUG flag. Also --enable-debug to get debug symbols in traces.

@fanquake fanquake added the Tests label Apr 30, 2021
@hebasto
Copy link
Member

hebasto commented Apr 30, 2021

https://cirrus-ci.com/task/5754102559801344 -- OOM

@fanquake
Copy link
Member

fanquake commented May 1, 2021

Note that DEBUG=1 is also set for depends in the previous releases job. Could add DEBUG to that description as part of this PR.

@maflcko
Copy link
Member Author

maflcko commented May 1, 2021

Thanks, will do

@maflcko maflcko closed this May 1, 2021
@maflcko maflcko deleted the 2104-ciDEBUG branch May 1, 2021 09:13
@maflcko
Copy link
Member Author

maflcko commented May 1, 2021

Closing because I wasn't aware this is already tested by another task

@maflcko maflcko restored the 2104-ciDEBUG branch May 1, 2021 09:16
@maflcko
Copy link
Member Author

maflcko commented May 1, 2021

Reopening because the other one is using gcc and this one is using clang

@maflcko maflcko reopened this May 1, 2021
@maflcko
Copy link
Member Author

maflcko commented May 1, 2021

Ok, addressed all feedback

@DrahtBot
Copy link
Contributor

DrahtBot commented May 1, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request May 1, 2021
Merged
@practicalswift
Copy link
Contributor

practicalswift commented May 2, 2021

Concept ACK

hebasto
hebasto approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa44f51, I have reviewed the code and it looks OK, I agree it can be merged, and CI is green.

@DrahtBot DrahtBot mentioned this pull request May 4, 2021
Closed
@fanquake fanquake merged commit 0ca8b7e into bitcoin:master May 4, 2021
@maflcko maflcko deleted the 2104-ciDEBUG branch May 4, 2021 12:53
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 5, 2021
@fanquake
Merge bitcoin#21812: ci: Enable D_GLIBCXX_DEBUG for multiprocess task
d281104
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@apoelstra
Merge 0ca8b7e into merged_master (Bitcoin PR bitcoin/bitcoin#21812)
488cc11
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hebasto hebasto hebasto approved these changes

+1 more reviewer

@iadeelzafar iadeelzafar iadeelzafar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fanquake fanquake

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maflcko @hebasto @fanquake @DrahtBot @practicalswift @iadeelzafar