test: Run feature_cltv with MiniWallet #21754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a8cc9f to
fa826d6
Compare
fa826d6 to
fac53d1
Compare
Contributor
|
Concept ACK: more |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Apr 22, 2021
fac53d1 to
fad5d81
Compare
added 3 commits
April 29, 2021 07:17
new_tx is a reference to tx. To avoid confusion and code-bloat, remove it
This avoids code-bloat and accidentally forgetting to call it
fad5d81 to
fa066f1
Compare
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 5, 2021
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
What a pain in the ass. This changes the `feature_cltv` functional test to use the `MiniWallet`, an internal Pythonic wallet that produces "signatures" consisting of several OP_NOPs in a row, so that this test can be used when the wallet is disabled. This means that the functions in feature_cltv which add a CLTV check and change the locktime/sequence number no longer need to re-sign when they change the txid, so they don't...HOWEVER, our Elements-specific `feature_block_v4` test calls these functions with a real transaction and depended on the re-signing behavior. After several attempts at min-effort min-diff fixes I landed on this, which simply sets the locktime at transaction creation and avoids having to re-sign at all. Also, I had to change the number of NOPs in the fake wallet code to make a vsize assertion pass, presumably because of differences in Bitcoin/Elements transaction serialization.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to run the test even with no wallet compiled in