Skip to content

Conversation

@dplusplus1024
Copy link
Contributor

vcpkg integrate install must be executed so that msbuild will automatically install external dependencies.

It was removed in 712f95d

It was originally added in 7644567

`vcpkg integrate install` must be executed so that msbuild will automatically install external dependencies.

It was removed in bitcoin@712f95d

It was originally added in bitcoin@7644567
@dplusplus1024 dplusplus1024 marked this pull request as ready for review April 19, 2021 22:50
@ddustin
Copy link

ddustin commented Apr 19, 2021

ACK

@sipsorcery
Copy link
Contributor

ACK de17d24.

I did shorten the vcpkg instructions when manifests were introduced. The idea being that msbuild would take care of calling vcpkg to install the dependencies automatically and it would be one less step.

Given that:

It's an ACK from me.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK de17d24, I use the same in #21551.

@maflcko maflcko merged commit 30a86bb into bitcoin:master Apr 20, 2021
@maflcko
Copy link
Member

maflcko commented Apr 20, 2021

Sorry, I missed the "Merge message contains an html comment!" warning when merging this. So the merge commit now contains an html comment.

gwillen pushed a commit to ElementsProject/elements that referenced this pull request Jun 1, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants