Skip to content

doc: Add release notes for #18335 #21484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Mar 29, 2021
Merged

doc: Add release notes for #18335 #21484

maflcko merged 1 commit into from
Mar 29, 2021

Conversation

@LarryRuane
Copy link
Contributor

@LarryRuane LarryRuane commented Mar 20, 2021

Follow-on to #18335

@fanquake fanquake added the Docs label Mar 20, 2021
@sipa
Copy link
Member

sipa commented Mar 20, 2021

Preferably put these in a doc/release-notes-18335.md file, so they don't get lost when release notes are aggregated for the next release.

@maflcko
Copy link
Member

maflcko commented Mar 20, 2021

@fanquake @sipa I asked the release notes to be put into the main file directly. This will save me time, because I don't have to aggregate the snippet (or anyone else doing the aggregation). IIRC the only reasons we started using snippets is:

  • Makes backport easier, because snippets only end up in the backports and can easily be removed from master.
  • Makes merge-conflicts less common for long-standing pull requests, because snippets don't conflict with each other.

None of the reasons apply here, because 18335 isn't tagged for backport and this pull request is not long-lived.

maflcko
maflcko reviewed Mar 20, 2021
View reviewed changes
doc/release-notes.md Outdated
Copy link
Member

@maflcko maflcko Mar 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anyone is using the cli as a stable interface. I was more referring to an http-rpc proxy receiving a different HTTP error code when the limit is exceeded.

maflcko
maflcko approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK beside nit

doc/release-notes.md Outdated
Copy link
Member

@maflcko maflcko Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `bitcoind` can process a limited number of simultaneous RPC requests.
- The RPC server can process a limited number of simultaneous RPC requests.

(You can run the RPC server via the gui as well)

jonatack
jonatack reviewed Mar 22, 2021
View reviewed changes
doc/release-notes.md Outdated
Copy link
Member

@jonatack jonatack Mar 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Now it returns the status code 503 (`HTTP_SERVICE_UNAVAILABLE`).
Now it returns status code 503 (`HTTP_SERVICE_UNAVAILABLE`). (#18335)

@LarryRuane LarryRuane closed this Mar 23, 2021
@LarryRuane
Copy link
Contributor Author

LarryRuane commented Mar 23, 2021

Force-pushed review comment suggestions, thanks Jon and Marco.

@darosior
Copy link
Member

darosior commented Mar 23, 2021

@LarryRuane i think you messed up your push, this ended up without any commit :)

@LarryRuane
Copy link
Contributor Author

LarryRuane commented Mar 23, 2021

Thanks, @darosior, I forgot to commit before push -f, should be fixed now.

@LarryRuane LarryRuane reopened this Mar 23, 2021
darosior
darosior approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@darosior darosior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 51eef4a

@maflcko maflcko merged commit 1184050 into bitcoin:master Mar 29, 2021
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 29, 2021
Merge bitcoin#21484: doc: Add release notes for bitcoin#18335
c6261f8 
51eef4a doc: Add release notes for bitcoin#18335 (rpc work queue exceeded error) (Larry Ruane)

Pull request description:

  Follow-on to bitcoin#18335

ACKs for top commit:
  darosior:
    ACK 51eef4a

Tree-SHA512: 863d92cb1c23493d9c8c42ed89b30ebd59092e44f159de4cefbabfe4101e7d7d40f24776ff3fcf39dedf90b45fc25845cf7a2177af38729ce2118d75c3cd779b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@jonatack jonatack jonatack left review comments

@maflcko maflcko maflcko approved these changes

@darosior darosior darosior approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LarryRuane @sipa @maflcko @darosior @jonatack @fanquake