doc: Add steps for Transifex to release process #21440

laanwj · 2021-03-15T06:59:14Z

Document how to update settings on and for the Transifex website before and after branch-off of a new release.

Document how to update settings on and for the transifex website before and after branch-off of a new release.

jarolrod · 2021-03-15T14:24:17Z

This documents how to set up the new translations on transifex. If you can, it would be nice to document how the translations actually get updated locally on the repo.

It seems that this script is used: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/update-translations.py?

DrahtBot · 2021-03-15T16:48:26Z

🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

RiccardoMasutti

ACK fbb6117

laanwj · 2021-03-16T13:11:20Z

This documents how to set up the new translations on transifex. If you can, it would be nice to document how the translations actually get updated locally on the repo.

This is documented already:

Before every release candidate

Update translations see translation_process.md.

Although it doesn't look like the documentation there is up to date. The .qrc nor .include needs to be updated manually anymore, the script takes care of that.

Edit: added a commit to fix this. Thanks!

These have been integrated into the script long ago.

jarolrod

Just missing a closing parentheses on line 45 🥃, also some nits (feel free to ignore)

jarolrod · 2021-03-16T18:23:31Z

doc/release-process.md

+- Translations on Transifex
+    - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with slug `[bitcoin.qt-translation-<RRR>x]` where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it.
+    - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
+    - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.


nit article usage

Suggested change

- Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.

- Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in the first step. This identifies which resource translations will be synchronized from.

jarolrod · 2021-03-16T18:35:37Z

doc/release-process.md

+    - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
+    - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.
+    - Make an announcement that translators can start translating for the new version. You can use one of the [previous announcements](https://www.transifex.com/bitcoin/bitcoin/announcements/) as a template.
+    - Change the resource auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.


nit on resource, seems to be used redundantly

nit, e.g normally is followed by a comma

missing closing parentheses

Suggested change

- Change the resource auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.

- Change the auto-update URL for the resource to `master`, e.g., `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.)

laanwj · 2021-03-16T18:48:06Z

@jarolrod Thanks for the suggestions!

jonatack

utACK modulo s/in first/in the first/, removing the extra "resource" and adding the missing closing parenthesis (all three pointed out by jarolrod). I think the e.g.'s are ok (just use commas consistently between lines 45 and 56).

hebasto

Approach ACK 9d08414, I verified changes against https://docs.transifex.com.

While here, maybe update

bitcoin/doc/translation_process.md

Line 107 in 4320bfc

    
           The Bitcoin-Core translation maintainers include *tcatm, seone, Diapolo, wumpus and luke-jr*. You can find them, and others, in the Freenode IRC chatroom - `irc.freenode.net #bitcoin-core-dev`.

?

hebasto · 2021-03-19T12:25:12Z

doc/release-process.md

+- Translations on Transifex
+    - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with slug `[bitcoin.qt-translation-<RRR>x]` where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it.
+    - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
+    - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.


nit:

Suggested change

- Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.

- Update the Transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.

hebasto · 2021-03-19T12:29:34Z

doc/release-process.md

+    - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
+    - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.
+    - Make an announcement that translators can start translating for the new version. You can use one of the [previous announcements](https://www.transifex.com/bitcoin/bitcoin/announcements/) as a template.
+    - Change the resource auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.


It is about master but in example <branch> is mentioned. Is it intended?

laanwj · 2021-03-19T13:08:11Z

Thanks for the review. I'm kind of intimidated by the number of proposed changes in these few lines, will get back to it later.

jarolrod · 2021-05-27T02:42:49Z

friendly ping @laanwj 🤗

jonatack · 2021-06-27T13:44:24Z

Here's a branch that addresses all of the review feedback, feel free to pull in/use/ignore:

https://github.com/jonatack/bitcoin/commits/update-transifex-release-process

jonatack · 2021-06-29T10:46:48Z

I reckon the PR author has other cats to herd at the moment so opened this in #22369.

fanquake · 2021-06-30T01:27:50Z

Going to close this for #22369.

a16378e doc: Remove unnecessary steps from translations update process (Wladimir J. van der Laan) 2584929 doc: Add steps for transifex to release process (Wladimir J. van der Laan) Pull request description: Document how to update settings on and for the transifex website before and after branch-off of a new release. (This is #21440, updated with the review feedback.) ACKs for top commit: laanwj: ACK a16378e hebasto: ACK a16378e Tree-SHA512: 9669cc3bc7ba056f913ee77c2ef9d9ee2313da947fc07f8cd955807c34c5d39e3af73587adfe734274ab2412a7dfb1e2dfe7ee4904ca28cfef9bf8061d26a573

doc: Add steps for transifex to release process

fbb6117

Document how to update settings on and for the transifex website before and after branch-off of a new release.

laanwj added the Docs label Mar 15, 2021

RiccardoMasutti approved these changes Mar 15, 2021

View reviewed changes

doc: Remove unnecessary steps from translations update process

9d08414

These have been integrated into the script long ago.

jarolrod reviewed Mar 16, 2021

View reviewed changes

jonatack reviewed Mar 16, 2021

View reviewed changes

hebasto reviewed Mar 19, 2021

View reviewed changes

jonatack mentioned this pull request Jun 29, 2021

doc: Add steps for Transifex to release process #22369

Merged

fanquake closed this Jun 30, 2021

bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022

	- Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.
	- Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in the first step. This identifies which resource translations will be synchronized from.

	- Change the resource auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.
	- Change the auto-update URL for the resource to `master`, e.g., `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.)

doc: Add steps for Transifex to release process #21440

doc: Add steps for Transifex to release process #21440

Uh oh!

Conversation

laanwj commented Mar 15, 2021

Uh oh!

jarolrod commented Mar 15, 2021

Uh oh!

DrahtBot commented Mar 15, 2021

Uh oh!

RiccardoMasutti left a comment

Choose a reason for hiding this comment

Uh oh!

laanwj commented Mar 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before every release candidate

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

jarolrod Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

jarolrod Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

laanwj commented Mar 16, 2021

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto Mar 19, 2021

Choose a reason for hiding this comment

Uh oh!

hebasto Mar 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Mar 19, 2021

Uh oh!

jarolrod commented May 27, 2021

Uh oh!

jonatack commented Jun 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack commented Jun 29, 2021

Uh oh!

fanquake commented Jun 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

laanwj commented Mar 16, 2021 •

edited

Loading

hebasto Mar 19, 2021 •

edited

Loading

jonatack commented Jun 27, 2021 •

edited

Loading