Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Mar 14, 2021

Update docs according to the recent changes in the code:

@fanquake fanquake added the Docs label Mar 14, 2021
@hebasto hebasto changed the title doc: Update zlib info in dependencies.md doc: Update dependencies.md Mar 14, 2021
@DrahtBot
Copy link
Contributor

🕵️ @harding @fanquake have been requested to review this pull request as specified in the REVIEWERS file.

@hebasto
Copy link
Member Author

hebasto commented Mar 16, 2021

Updated f168e06 -> bb3f79f (pr21435.01 -> pr21435.02, diff):

@laanwj
Copy link
Member

laanwj commented Mar 16, 2021

Thanks, LGTM now


#### Other
* librsvg is only needed if you need to run `make deploy` on (cross-compilation to) macOS.
* Not-Qt-bundled zlib is required to build the [DMG tool](../contrib/macdeploy/README.md#deterministic-macos-dmg-notes) from the libdmg-hfsplus project.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can just be zlib

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb3f79f - thanks for keeping this updated.

@fanquake fanquake merged commit bf7c22f into bitcoin:master Mar 18, 2021
@hebasto hebasto deleted the 210314-deps branch March 18, 2021 07:53
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 18, 2021
bb3f79f doc: Update libnatpmp info in dependencies.md (Hennadii Stepanov)
1a01a5d doc: Update zlib info in dependencies.md (Hennadii Stepanov)

Pull request description:

  Update docs according to the recent changes in the code:
  - bitcoin#21209 (zlib)
  - bitcoin#21376 (libnatpmp)

ACKs for top commit:
  fanquake:
    ACK bb3f79f - thanks for keeping this updated.

Tree-SHA512: 48350ad07700aa071ad6c34e4c161aaadc050488fc068cf478e9781d632828187962a4384c1b67c2344145a2c00c3e16cddd09259130af8e9e86cd76cd32900d
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants