-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: Update dependencies.md #21435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
doc: Update dependencies.md #21435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laanwj
reviewed
Mar 16, 2021
Member
Author
|
Updated f168e06 -> bb3f79f (pr21435.01 -> pr21435.02, diff): |
Member
|
Thanks, LGTM now |
fanquake
reviewed
Mar 17, 2021
|
|
||
| #### Other | ||
| * librsvg is only needed if you need to run `make deploy` on (cross-compilation to) macOS. | ||
| * Not-Qt-bundled zlib is required to build the [DMG tool](../contrib/macdeploy/README.md#deterministic-macos-dmg-notes) from the libdmg-hfsplus project. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can just be zlib
fanquake
approved these changes
Mar 18, 2021
Member
fanquake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK bb3f79f - thanks for keeping this updated.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 18, 2021
bb3f79f doc: Update libnatpmp info in dependencies.md (Hennadii Stepanov) 1a01a5d doc: Update zlib info in dependencies.md (Hennadii Stepanov) Pull request description: Update docs according to the recent changes in the code: - bitcoin#21209 (zlib) - bitcoin#21376 (libnatpmp) ACKs for top commit: fanquake: ACK bb3f79f - thanks for keeping this updated. Tree-SHA512: 48350ad07700aa071ad6c34e4c161aaadc050488fc068cf478e9781d632828187962a4384c1b67c2344145a2c00c3e16cddd09259130af8e9e86cd76cd32900d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs according to the recent changes in the code: