test: bring p2p_leak.py up to date #21345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the introduction of wtxidrelay and sendaddrv2 messages during version handshake, extend p2p_leak.py test to reflect this. Also, some minor fixes and doc improvements.
brunoerg
reviewed
Mar 3, 2021
| def bad_message(self, message): | ||
| self.unexpected_msg = True | ||
| self.log.info("should not have received message: %s" % message.msgtype) | ||
| print("should not have received message: %s" % message.msgtype) |
Contributor
There was a problem hiding this comment.
Is there a reason to replace self.log.info with print?
Contributor
Author
There was a problem hiding this comment.
Yes - I think it would have caused a crash before because we are inside P2PInterface which doesn't have a log - only BitcoinTestFramework does.
Contributor
|
Tested ACK a061a29
|
theStack
approved these changes
Mar 4, 2021
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 5, 2021
a061a29 test: bring p2p_leak.py up to date. (Martin Zumsande) Pull request description: After the introduction of wtxidrelay and sendaddrv2 messages during version handshake, extend p2p_leak.py test to reflect this. Also, some minor fixes and doc improvements. I also added a test that peers not completing the version handshake will be disconnected for timeout, as suggested by MarcoFalke in bitcoin#19723 (comment). ACKs for top commit: brunoerg: Tested ACK a061a29 theStack: Tested ACK a061a29 Tree-SHA512: 26c601491fa8710fc972d1b8f15da6b387a95b42bbfb629ec4c668769ad3824b6dd6a33d97363bca2171e403d8d1ce08abf3e5c9cab34f98d53e0109b1c7a0e5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the introduction of wtxidrelay and sendaddrv2 messages during version handshake, extend p2p_leak.py test to reflect this.
Also, some minor fixes and doc improvements.
I also added a test that peers not completing the version handshake will be disconnected for timeout, as suggested by MarcoFalke in #19723 (comment).