doc: Correction for VerifyTaprootCommitment comments #21246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 56325c9be7a6ea3717efdf2ec5f244a659f26452 Only three comments in interpreter.cpp that refer to "inner key", all of them replaced in this PR. No reference to "inner key" in BIP 341 |
theStack
reviewed
Feb 22, 2021
Contributor
theStack
left a comment
There was a problem hiding this comment.
Note that there are also some occurences of "inner pubkey" in the functional taproot test and a test framework script helper module that could be tackled in this PR:
$ git grep "inner pubkey"
src/script/interpreter.cpp: //! The inner pubkey (x-only, so no Y coordinate parity).
src/script/interpreter.cpp: // Compute the tweak from the Merkle root and the inner pubkey.
src/script/interpreter.cpp: // Verify that the output pubkey matches the tweaked inner pubkey, after correcting for parity.
test/functional/feature_taproot.py: # The inner pubkey for a taproot script path spend (32 bytes).
test/functional/feature_taproot.py: # The negation flag of the inner pubkey for a taproot script path spend.
test/functional/feature_taproot.py: # Test that bitflips in the inner pubkey invalidate it.
test/functional/test_framework/script.py:# - inner_pubkey: the inner pubkey (32 bytes)
According to BIP-341, 'p' is called the taproot *internal* key, not inner key.
56325c9 to
6a0a6e7
Compare
theStack
approved these changes
Mar 1, 2021
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 5, 2021
…ents 6a0a6e7 Correction for VerifyTaprootCommitment comments (Russell O'Connor) Pull request description: According to BIP-341, 'p' is called the taproot *internal* key, not inner key. ACKs for top commit: sipa: ACK 6a0a6e7 benthecarman: ACK 6a0a6e7 theStack: ACK 6a0a6e7 Tree-SHA512: 94f553476a8404bff4b2d5724a1a54c5f530b987a616cd00a3800095f245c06e3c7a9066c729976f32069a56029406859a70ba523151d333dc1ed874f242bce8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to BIP-341, 'p' is called the taproot internal key, not inner key.