test: update documentation in feature_csv_activation.py #20857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theStack
approved these changes
Apr 17, 2021
Contributor
theStack
left a comment
There was a problem hiding this comment.
ACK e2a206329fca3158e25e8a7b279e92ec8763a04b
Verified that the numbers match, also the grammar/stylistic changes LGTM.
jonatack
reviewed
Apr 17, 2021
Member
There was a problem hiding this comment.
nit, I think there's no need to change "block chain"; see https://github.com/bitcoinops/bitcoinops.github.io/blob/master/STYLE.md#compound-words
Contributor
Author
There was a problem hiding this comment.
I reverted this change. Thanks for the link.
These changes in the test documentation reflect the changes introduced in bitcoin#17921
Member
|
review ACK 9053b88 checked that COINBASE_BLOCK_COUNT is 83. didn't check the other constant |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 19, 2021
…tion.py 9053b88 update docstring in feature_csv_activation.py (Pierre K) Pull request description: These changes in the test documentation reflect the changes introduced in bitcoin#17921. ACKs for top commit: MarcoFalke: review ACK 9053b88 Tree-SHA512: 17fb954baded8dab1c869dd48b76b516150bae616c792c573e4114d4adfdd40195745c56570aa3050cc0015ee496acd7ec178df8ba14831dd22f9722fda84da2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes in the test documentation reflect the changes introduced in #17921.