util: Allow use of C++14 chrono literals #20602
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK |
Contributor
|
Concept ACK. |
Member
Author
Yes, it is possible to change existing code, but as this is a purely stylistic change, it might be better to do it when the code is touched for other reasons. The only goal of this pull is to pull in the namespace and show that it was pulled in by replacing a few lines. |
Member
|
Concept ACK. I've put #20253 on top of this. Will make sure to remember |
jonatack
reviewed
Dec 9, 2020
| #include <string> | ||
| #include <chrono> | ||
|
|
||
| using namespace std::chrono_literals; |
Member
There was a problem hiding this comment.
trivia, both this and using namespace std::literals::chrono_literals; appear to be valid
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 9, 2020
fa11110 util: Allow use of C++14 chrono literals (MarcoFalke) Pull request description: I think we should allow the use of chrono literals for new code to make it less verbose. Obviously old code can stay as-is. This patch pulls in the needed namespace and replaces some lines for illustrative purposes. ACKs for top commit: vasild: ACK fa11110 jonatack: ACK fa11110 Tree-SHA512: ee2b72c8f28dee07b33b9a8ee8f7c87c0bc43b05c56a17b786cf9803ef204c7628e01b02de1af1a4eb01f5cdf6fc336f69c2833e17acd606ebda20ac6917e6bb
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 26, 2022
Summary: ``` I think we should allow the use of chrono literals for new code to make it less verbose. Obviously old code can stay as-is. This patch pulls in the needed namespace and replaces some lines for illustrative purposes. ``` Backport of [[bitcoin/bitcoin#20602 | core#20602]]. Ref T1696. Test Plan: ninja all check-all Build for Windows. Reviewers: #bitcoin_abc, tyler-smith Reviewed By: #bitcoin_abc, tyler-smith Subscribers: tyler-smith Maniphest Tasks: T1696 Differential Revision: https://reviews.bitcoinabc.org/D10901
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should allow the use of chrono literals for new code to make it less verbose. Obviously old code can stay as-is.
This patch pulls in the needed namespace and replaces some lines for illustrative purposes.