Skip to content

Add depends qt fix for ARM macs #20482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Dec 7, 2020
Merged

Add depends qt fix for ARM macs #20482

laanwj merged 1 commit into from
Dec 7, 2020

Conversation

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Nov 24, 2020

With this, depends builds fine on macOS 11 on an Apple Silicon Mac (ARM64).

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Nov 24, 2020

cross compiling apple arm64 (aarch64-apple-darwin) on a linux host will requires some more work.

@luke-jr
Copy link
Member

luke-jr commented Nov 24, 2020

Concept ACK.

Did you check if various aarch64 assembly bits (libsecp256k1?) work correclty? I seem to recall reading that Apple's aarch64 isn't 100% compatible with normal aarch64...

P.S. AIUI, aarch64 is not actually related to the 'arm' architecture.

@jonasschnelli
Copy link
Contributor Author

jonasschnelli commented Nov 24, 2020

Did you check if various aarch64 assembly bits (libsecp256k1?) work correclty? I seem to recall reading that Apple's aarch64 isn't 100% compatible with normal aarch64...

I did a full IBD on an apple ARM64 M1 (not using the Rosetta 2 X86 virtualisation).

P.S. AIUI, aarch64 is not actually related to the 'arm' architecture.

AFAIK AArch64 is an optional 64bit architecture implemented by >=ARMv8? But it is confusing anyways.

@sipa
Copy link
Member

sipa commented Nov 24, 2020 •
edited
Loading

@luke-jr libsecp256k1 only has 32-bit ARM asm code, and it's not enabled by default in Bitcoin Core builds.

@laanwj
Copy link
Member

laanwj commented Nov 25, 2020

Concept ACK, glad so see that it built with so few changes.

@jonasschnelli jonasschnelli mentioned this pull request Nov 25, 2020
Closed
5 tasks
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 26, 2020

Guix builds

File commit afdfd3c
(master)		 commit 45974345373221aab3f8f6d0efdc173b2843a1e5
(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz 321e361023e8ea7b... a5a04407cb3d74b8...
*-aarch64-linux-gnu.tar.gz b054d1129516836e... fe5fde82b6c7d624...
*-arm-linux-gnueabihf-debug.tar.gz cdd6185a356e7a80... 1d27fabdc960b139...
*-arm-linux-gnueabihf.tar.gz 4db9b1126b6601b7... 208e7f16c3032fe6...
*-riscv64-linux-gnu-debug.tar.gz df4a6eb0267f7140... c26a09f01f343e8b...
*-riscv64-linux-gnu.tar.gz 3ff6d83bd5983e2b... 1bd23db97e9c4bd1...
*-win-unsigned.tar.gz 0dbc83ed5f22a4db... d986246315c80e67...
*-win64-debug.zip 539b210aa13b56bc... 95e355a36c30810d...
*-win64-setup-unsigned.exe 5ff779deff3db721... 338d6f58ee18902d...
*-win64.zip 4e50c84031e8b116... 9f7d2f603bf7fa86...
*-x86_64-linux-gnu-debug.tar.gz 345daa571d3557b0... f187c263986f3f02...
*-x86_64-linux-gnu.tar.gz 60655c6fb26e8633... 86ebd75b08f11060...
*.tar.gz 0ddcf17cb856ed92... 370f79f93884d76e...
guix_build.log 6670400b0a6511d0... 06fe186719cd63dc...
guix_build.log.diff 3864811e9ad9319a...

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 26, 2020 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@DrahtBot DrahtBot mentioned this pull request Nov 26, 2020
Closed
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 29, 2020

Gitian builds

File commit e2ff5e7
(master)		 commit bc5f2b9ee971a2d4a7468c63e07b82deca93a175
(master and this pull)
bitcoin-core-linux-22-res.yml 44e52af36236879f... b5895d49e61d0ac9...
bitcoin-core-osx-22-res.yml 71d5fb0e6642d6b0... 6a1679fa67603bff...
bitcoin-core-win-22-res.yml 0148a2f5e7295184... 20f9506be98c3c65...
*-aarch64-linux-gnu-debug.tar.gz 383e84aaa96f342a... 7dcc4170bca617bc...
*-aarch64-linux-gnu.tar.gz 3558211891c0484a... fbd5ec07ec47c0bf...
*-arm-linux-gnueabihf-debug.tar.gz 5ebbb475a590480a... 230472cd7c4b0c84...
*-arm-linux-gnueabihf.tar.gz 60951d893e2688b6... 50b9c33b2b68d4a8...
*-osx-unsigned.dmg 7cba6edda598c96c... 67f2ccede9f96831...
*-osx64.tar.gz ea2ab5c893780a2e... bdf45bf6ae475f67...
*-riscv64-linux-gnu-debug.tar.gz 0c20a43923efcd5f... 59b3486072dd3a53...
*-riscv64-linux-gnu.tar.gz 8d3632d81c77eff1... 5c821fb948099519...
*-win64-debug.zip 72c35e133cf9a0db... 5c5fe4a050f37923...
*-win64-setup-unsigned.exe 55c17bfff54273e5... 55d659d6b5d14dda...
*-win64.zip f7bf6737c7f741c3... f7def119620dc76c...
*-x86_64-linux-gnu-debug.tar.gz abf91baef5c44686... 9f4b7946dc3a3c1a...
*-x86_64-linux-gnu.tar.gz 75fda490174df335... 6152ecfb5058a1f9...
*.tar.gz 793a2c7af39452d5... b1ac4913e6c09436...
linux-build.log 9c5461a914e1f4c0... 393a3922a89086ab...
osx-build.log 5adaf67afbaf00fc... 448032ad16eccc03...
win-build.log 756101ecccffabf0... eb2188fda5c43a83...
bitcoin-core-linux-22-res.yml.diff 9c0bbf79417d5979...
bitcoin-core-osx-22-res.yml.diff 793b672afa2c7dfb...
bitcoin-core-win-22-res.yml.diff 609abc0827da46fc...
linux-build.log.diff 18255436264ba93e...
osx-build.log.diff 7fb8f7eff038c67f...
win-build.log.diff 345b25722c8b48ac...

@fanquake
Copy link
Member

fanquake commented Nov 30, 2020

Concept ACK - no hardware to test this on though.

@laanwj
Copy link
Member

laanwj commented Dec 3, 2020

Looks like this upstream bug is not solved in any releases. So it won't just go away with a more recent Qt (at least not one we're going to upgrade to before 0.22).

@laanwj
Copy link
Member

laanwj commented Dec 7, 2020 •
edited
Loading

Code review ACK c23f6f8

@laanwj laanwj merged commit 31438cc into bitcoin:master Dec 7, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 7, 2020
@laanwj
Merge bitcoin#20482: Add depends qt fix for ARM macs
84408c7 
c23f6f8 Add depends qt fix for ARM macs (Jonas Schnelli)

Pull request description:

  With this, depends builds fine on macOS 11 on an Apple Silicon Mac (ARM64).

ACKs for top commit:
  laanwj:
    Code review ACK c23f6f8

Tree-SHA512: a8354cec99969cff9e7dab150c335050ddb4b3c93a9f12a4db5e8046f02b11ce692ac17c2b96cbbe7f380c1aa110b15b8d6d48d51bc9c560282c702e99fd8a8d
@fanquake fanquake mentioned this pull request Jun 2, 2021
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#20482: Add depends qt fix for ARM macs
01b4ac5 
c23f6f8 Add depends qt fix for ARM macs (Jonas Schnelli)

Pull request description:

  With this, depends builds fine on macOS 11 on an Apple Silicon Mac (ARM64).

ACKs for top commit:
  laanwj:
    Code review ACK c23f6f8

Tree-SHA512: a8354cec99969cff9e7dab150c335050ddb4b3c93a9f12a4db5e8046f02b11ce692ac17c2b96cbbe7f380c1aa110b15b8d6d48d51bc9c560282c702e99fd8a8d
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 16, 2021
@laanwj @PastaPastaPasta
Merge bitcoin#20482: Add depends qt fix for ARM macs
9ff3643 
c23f6f8 Add depends qt fix for ARM macs (Jonas Schnelli)

Pull request description:

  With this, depends builds fine on macOS 11 on an Apple Silicon Mac (ARM64).

ACKs for top commit:
  laanwj:
    Code review ACK c23f6f8

Tree-SHA512: a8354cec99969cff9e7dab150c335050ddb4b3c93a9f12a4db5e8046f02b11ce692ac17c2b96cbbe7f380c1aa110b15b8d6d48d51bc9c560282c702e99fd8a8d
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Build system GUI macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jonasschnelli @luke-jr @sipa @laanwj @DrahtBot @fanquake @maflcko