Skip to content

doc: Update wallet files in files.md #20152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Oct 27, 2020
Merged

doc: Update wallet files in files.md #20152

fanquake merged 1 commit into from
Oct 27, 2020

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Oct 15, 2020

This PR is a #19077 follow up, and it addresses the comment:

If need to update, there are two corrections that could be made:

  • Line 69 "Wallets are Berkeley DB (BDB) databases" is no longer true

  • Line 76 "Wallet lock file" should say "BDB wallet lock file"

@fanquake fanquake added the Docs label Oct 15, 2020
@hebasto
Copy link
Member Author

hebasto commented Oct 15, 2020

cc @ryanofsky @achow101 @meshcollider

@maflcko maflcko added this to the 0.21.0 milestone Oct 15, 2020
@hebasto hebasto mentioned this pull request Oct 15, 2020
Merged
RiccardoMasutti
RiccardoMasutti approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@RiccardoMasutti RiccardoMasutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK defe48a

meshcollider
meshcollider reviewed Oct 19, 2020
View reviewed changes
Copy link
Contributor

@meshcollider meshcollider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK defe48a

@fanquake fanquake merged commit 67d4643 into bitcoin:master Oct 27, 2020
@hebasto hebasto deleted the 201015-sqlite branch October 27, 2020 07:48
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 27, 2020
@fanquake
Merge bitcoin#20152: doc: Update wallet files in files.md
4e8d3dc 
defe48a doc: Update wallet files in files.md (Hennadii Stepanov)

Pull request description:

  This PR is a bitcoin#19077 follow up, and it addresses the [comment](bitcoin#19077 (comment)):

  > If need to update, there are two corrections that could be made:
  >
  >  * Line 69 "Wallets are Berkeley DB (BDB) databases" is no longer true
  >
  >  * Line 76 "Wallet lock file" should say "BDB wallet lock file"

ACKs for top commit:
  RiccardoMasutti:
    ACK defe48a
  meshcollider:
    ACK defe48a

Tree-SHA512: 39939f86a9c7842bf06913998305dcbd6209585f1da0fe9c274bac0572eb8464e59176884dd9e2b91312f34efad40cdeb4085ec72c2a2c1b33d16b6ab505140c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@meshcollider meshcollider meshcollider left review comments

@RiccardoMasutti RiccardoMasutti RiccardoMasutti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

0.21.0

Development

Successfully merging this pull request may close these issues.

5 participants

@hebasto @meshcollider @RiccardoMasutti @fanquake @maflcko