net: improve nLastBlockTime and nLastTXTime documentation #19857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: John Newbery <john@johnnewbery.com>
Contributor
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Sep 1, 2020
Member
|
ACK d780293 |
Contributor
|
ACK d780293 Great to see Optech collaboration resulting in improved documentation! |
Contributor
|
ACK d780293 |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 22, 2021
Summary: ``` [...] help alleviate confusion around nLastBlockTime and nLastTXTime, now also provided by the JSON-RPC API as last_block and last_transaction in getpeerinfo output. ``` Backport of [[bitcoin/bitcoin#19857 | core#19857]]. Depends on D9331. Test Plan: Read the comments. Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9332
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 24, 2021
…mentation d780293 net: improve nLastBlockTime and nLastTXTime documentation (Jon Atack) Pull request description: Follow-up to bitcoin#19731 to help alleviate confusion around `nLastBlockTime` and `nLastTXTime`, now also provided by the JSON-RPC API as `last_block` and `last_transaction` in `getpeerinfo` output. Thanks to John Newbery, credited in the commit, and to Dave Harding and Adam Jonas during discussions on how to best explain these in this week's Optech newsletter. ACKs for top commit: practicalswift: ACK d780293 MarcoFalke: ACK d780293 harding: ACK d780293 . The added documentation matches my reading of the code and answers a question I had after seeing bitcoin#19731 0xB10C: ACK d780293 Tree-SHA512: 72d47cf50a099913c7e4753cb80e11785b26fb66fa3a8b6c382fde4ea725116f3d215f93d32a567246d269768e66159f8dcf017a1bbc6d5f2489a35f81c316fa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #19731 to help alleviate confusion around
nLastBlockTimeandnLastTXTime, now also provided by the JSON-RPC API aslast_blockandlast_transactioningetpeerinfooutput.Thanks to John Newbery, credited in the commit, and to Dave Harding and Adam Jonas during discussions on how to best explain these in this week's Optech newsletter.