test: Mockwallet #19800
Merged
test: Mockwallet #19800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Requested by @jnewbery in #19315 (comment) |
jnewbery
reviewed
Aug 25, 2020
Contributor
jnewbery
left a comment
There was a problem hiding this comment.
Very cool. Strong concept ACK if this allows us to build transactions outside the wallet more easily.
faa2aa2 to
fa8b892
Compare
fa8b892 to
faf4f21
Compare
Member
Author
|
nowallet build passed: https://travis-ci.org/github/bitcoin/bitcoin/jobs/720986253#L3238 |
jonatack
reviewed
Aug 25, 2020
Member
jonatack
left a comment
There was a problem hiding this comment.
Concept ACK, tested ACK, very nice.
A few style nits below, feel free to ignore.
faf4f21 to
fa170e5
Compare
instagibbs
reviewed
Aug 25, 2020
Contributor
|
concept ACK!! very nice :) |
Contributor
|
Concept ACK |
Member
Author
|
Would be good to make progress here, so that the mockwallet can be used in new tests |
jnewbery
reviewed
Sep 7, 2020
Contributor
jnewbery
left a comment
There was a problem hiding this comment.
This is great. I've left lots of small style comments. Nothing blocking though.
fa170e5 to
fae0de3
Compare
Member
Author
|
Force pushed second commit to address @jnewbery's feedback |
Contributor
|
utACK fae0de34945dce7582ac53c90c7b84e1c478a8bc |
fae0de3 to
fa188c9
Compare
Contributor
|
utACK fa188c9 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 9, 2020
fa188c9 test: Use MiniWalet in p2p_feefilter (MarcoFalke) fa39c62 test: inline hashToHex (MarcoFalke) Pull request description: This introduces a minimalistic test wallet, which can be used as a drop in replacement for the Bitcoin Core wallet to create dummy transactions with a given fee rate. ACKs for top commit: jnewbery: utACK fa188c9 Tree-SHA512: 0aad9cb14eea4f0055bd6a47cc8c8f82a16941b152598c3bf1e083aae84cca4ffa23f0b854a362a68be1b917deba1b5ec7c0207b63b0805d747ba9a7d1d82efe
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 11, 2021
Summary: > This introduces a minimalistic test wallet, which can be used as a drop in replacement for the Bitcoin Core wallet to create dummy transactions with a given fee rate. This is a backport of [[bitcoin/bitcoin#19800 | core#19800]] It is squashed with the first bugfix commit of core#19922: bitcoin/bitcoin@fa65a11 Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10199
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a minimalistic test wallet, which can be used as a drop in replacement for the Bitcoin Core wallet to create dummy transactions with a given fee rate.