Move comment about BaseIndex::DB from TxIndex::DB #19733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
reviewed
Aug 16, 2020
Contributor
promag
left a comment
There was a problem hiding this comment.
ACK 68b597b81395e026e299bca05e46312f273f812b.
Contributor
|
ACK 68b597b81395e026e299bca05e46312f273f812b |
Member
|
Needs rebase, and I see your previous commit had some apparent unused includes. If you agree, you can add a commit here to remove them: diff --git a/src/index/disktxpos.h b/src/index/disktxpos.h
index 8cd2270028..129f9dc7c0 100644
--- a/src/index/disktxpos.h
+++ b/src/index/disktxpos.h
@@ -5,10 +5,8 @@
#ifndef BITCOIN_INDEX_DISKTXPOS_H
#define BITCOIN_INDEX_DISKTXPOS_H
-#include <chain.h>
#include <flatfile.h>
-#include <primitives/block.h>
-#include <primitives/transaction.h>
+#include <serialize.h>
struct CDiskTxPos : public FlatFilePos
{
@@ -33,5 +31,4 @@ struct CDiskTxPos : public FlatFilePos
}
};
-
#endif // BITCOIN_INDEX_DISKTXPOS_H |
68b597b to
c8463bd
Compare
c8463bd to
8ed2f1e
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
approved these changes
Aug 21, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 21, 2020
8ed2f1e Remove unused includes (Marcin Jachymiak) cf095a5 Move comment about BaseIndex::DB from TxIndex::DB (Marcin Jachymiak) Pull request description: Moves a comment about the `BaseIndex::DB` from the `TxIndex::DB` into the correct place. Originally part of bitcoin#14053. ACKs for top commit: fanquake: ACK 8ed2f1e Tree-SHA512: cb4e2b916c7ab996961cc2e1d910bc4b8a1700eb32b70fc1657ca720117a7a84f7337fe5e4fb30e047aa92c31eaa976eaaa5cb8f861877f2ff6f4a59bb94f4e9
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Sep 15, 2021
8ed2f1e Remove unused includes (Marcin Jachymiak) cf095a5 Move comment about BaseIndex::DB from TxIndex::DB (Marcin Jachymiak) Pull request description: Moves a comment about the `BaseIndex::DB` from the `TxIndex::DB` into the correct place. Originally part of bitcoin#14053. ACKs for top commit: fanquake: ACK 8ed2f1e Tree-SHA512: cb4e2b916c7ab996961cc2e1d910bc4b8a1700eb32b70fc1657ca720117a7a84f7337fe5e4fb30e047aa92c31eaa976eaaa5cb8f861877f2ff6f4a59bb94f4e9
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 15, 2021
Summary: And remove unused includes This is a backport of [[bitcoin/bitcoin#19733 | core#19733]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10119
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Sep 22, 2021
8ed2f1e Remove unused includes (Marcin Jachymiak) cf095a5 Move comment about BaseIndex::DB from TxIndex::DB (Marcin Jachymiak) Pull request description: Moves a comment about the `BaseIndex::DB` from the `TxIndex::DB` into the correct place. Originally part of bitcoin#14053. ACKs for top commit: fanquake: ACK 8ed2f1e Tree-SHA512: cb4e2b916c7ab996961cc2e1d910bc4b8a1700eb32b70fc1657ca720117a7a84f7337fe5e4fb30e047aa92c31eaa976eaaa5cb8f861877f2ff6f4a59bb94f4e9
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Sep 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves a comment about the
BaseIndex::DBfrom theTxIndex::DBinto the correct place. Originally part of #14053.