doc: set CC_FOR_BUILD when building on OpenBSD #19605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: bitcoin#19559 While bitcoin#19559 has been fixed upstream, it makes sense to not only recommend using `CC_FOR_BUILD`here until the fix is pulled in as part of our next libsecp update, but after discussing with Cory, he suggested we should be setting this on OpenBSD (which still has the an ancient GCC) regardless.
Contributor
|
ACK 01cd24c I looked at the diff (but can't test the instructions on OpenBSD) Setting |
Member
|
Code review ACK 01cd24c |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 10, 2020
01cd24c doc: set CC_FOR_BUILD when building on OpenBSD (fanquake) Pull request description: Closes: bitcoin#19559 While bitcoin#19559 has been fixed upstream, it makes sense to not only recommend using `CC_FOR_BUILD`here until the fix is pulled in as part of our next libsecp update, but after discussing with Cory, he suggested we should be setting this on OpenBSD (which still has the an ancient GCC) regardless. ACKs for top commit: real-or-random: ACK 01cd24c I looked at the diff (but can't test the instructions on OpenBSD) laanwj: Code review ACK 01cd24c Tree-SHA512: 322802b9303771f1be2ad9628f268dfa71dc7ee77948fa2a34f21eceb19b2d8efdd8876c8f0778adbfcde48fa0f88cd4e698ae425428159abca38e8c7980da1d
Contributor
|
bitcoin-core/secp256k1#862 has just been merged, which will make setting CC_FOR_BUILD unnecessary (after the next update of the secp256k1 subtree). Not sure if we want to change the docs. It certainly does not hurt to set the variable. 🤷 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #19559
While #19559 has been fixed upstream, it makes sense to not only
recommend using
CC_FOR_BUILDhere until the fix is pulled in aspart of our next libsecp update, but after discussing with Cory,
he suggested we should be setting this on OpenBSD (which still has
the an ancient GCC) regardless.