Skip to content

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jul 1, 2020

Fixes bitcoin-core/gui#12

Copied description from #19321:

Currently it is not possible to use travis in forked repositories due to the 50 minute limit on builds. A fresh build (uncached) of the thread sanitizer config takes more than 50 minutes.

One approach to fix this could be to throw away tests until the run time is less than 50 minutes. However, the risk of being blind of failures in the thrown away tests is not worth the gain. Also, to detect them, one has to run the tsan configuration nightly and failures could only be detected post-merge.

Another approach would be to ask travis support to raise the limit for a forked repository. This is a tedious and manual one-by-one process, so I'd rather not.

Finally, a different ci provider can be used, since the config files are designed to be platform-agnostic. This is what I picked.

I kept all settings identical to the travis machine for now. Both providers run in the google cloud, so this should be a "move-only".

@DrahtBot DrahtBot added the Tests label Jul 1, 2020
@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 1, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@maflcko maflcko force-pushed the 2006-ciTsanCirrus branch from fa798f4 to fa8e6df Compare July 2, 2020 16:24
@maflcko
Copy link
Member Author

maflcko commented Jul 2, 2020

Rebased

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa8e6df - my understanding is that test coverage remains the same. Just swapping providers to work-around the Travis time-limit in other repos.

@maflcko maflcko merged commit 3276c14 into bitcoin:master Jul 3, 2020
@maflcko maflcko deleted the 2006-ciTsanCirrus branch July 3, 2020 11:42
maflcko pushed a commit that referenced this pull request Aug 19, 2020
fa0538e ci: Set cirrus RAM to 8GB (MarcoFalke)
fa41810 ci: Run valgrind fuzzer on cirrus (MarcoFalke)

Pull request description:

  The first commit should fix the 50min timeout in forked repos. Similar to #19424. E.g. https://travis-ci.org/github/bitcoin-core/gui/builds/718322267

  The second commit should fix #19744

Top commit has no ACKs.

Tree-SHA512: c765098dfa913ca49b1d1eee99aaa83e4b9eb191b7ad5e652e3f04744fe8670dd3ef4215832b8e2b5bac0273d24f607fc275e72f566326108ba42ab57228ffd4
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 19, 2020
fa0538e ci: Set cirrus RAM to 8GB (MarcoFalke)
fa41810 ci: Run valgrind fuzzer on cirrus (MarcoFalke)

Pull request description:

  The first commit should fix the 50min timeout in forked repos. Similar to bitcoin#19424. E.g. https://travis-ci.org/github/bitcoin-core/gui/builds/718322267

  The second commit should fix bitcoin#19744

Top commit has no ACKs.

Tree-SHA512: c765098dfa913ca49b1d1eee99aaa83e4b9eb191b7ad5e652e3f04744fe8670dd3ef4215832b8e2b5bac0273d24f607fc275e72f566326108ba42ab57228ffd4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Tsan times out on travis, move to cirrus

3 participants