tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests #19140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid constructing requests that will be interpreted by libevent as PROXY requests to avoid triggering a
nullptrdereference. Split out from #19074 as suggested by MarcoFalke.The dereference (
req->evcon->http_server) takes place inevhttp_parse_request_lineand is a consequence of our hacky but necessary use of the internal functionevhttp_parse_firstline_in thehttp_requestfuzzing harness.The suggested workaround is not aesthetically pleasing, but it successfully avoids the troublesome code path.
" http:// HTTP/1.1\n"was a crashing input prior to this workaround.Before this PR:
After this PR:
See
doc/fuzzing.mdfor information on how to fuzz Bitcoin Core. Don't forget to contribute any coverage increasing inputs you find to the Bitcoin Core fuzzing corpus repo.Happy fuzzing :)