rpc: Make gettxoutsetinfo/GetUTXOStats interruptible #19056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2020 15:52
Also, add interruption points to scantxoutset
fa01df5 to
fa75692
Compare
Member
Author
|
Can be tested with the cli: |
Contributor
|
Code Review ACK fa75692 |
Member
|
@MarcoFalke mind looking into #17659 ? |
Member
|
Concept ACK. |
hebasto
reviewed
May 24, 2020
hebasto
reviewed
May 24, 2020
Member
hebasto
left a comment
There was a problem hiding this comment.
While touching the body of FindScriptPubKey() is it a good chance to make it static?
Member
|
Code review ACK fa75692 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 27, 2020
…ible fa75692 rpc: Make gettxoutsetinfo/GetUTXOStats interruptible (MarcoFalke) fa7fc5a rpc: factor out RpcInterruptionPoint from dumptxoutset (MarcoFalke) Pull request description: Make it interruptible, so that shutdown doesn't block for up to one hour. Fixes (partially) bitcoin#13217 ACKs for top commit: Empact: Code Review ACK bitcoin@fa75692 laanwj: Code review ACK fa75692 Tree-SHA512: 298261e0ff7d79fab542b8f6828cc0ac451cbafe396d5f0816c9d36437faba1330f5c4cb2a25c5540e202bfb9783da6ec858bd453056ce488d21e36335d3d42c
maflcko
pushed a commit
that referenced
this pull request
Jul 14, 2020
314b49b gui: Fix regression in GUI console (Hennadii Stepanov) Pull request description: The regression was introduced in #19056: if the GUI is running without `-server=1`, the `*txoutset*` call in the console returns "Shutting down". Fix #19255. ACKs for top commit: ryanofsky: Code review ACK 314b49b. Only change since last review is rebase Tree-SHA512: 8ff85641a5c249858fecb1ab69c7a1b2850af651ff2a94aa41ce352b5b5bc95bc45c41e1767e871b51e647612d09e4d54ede3e20c313488afef5678826c51b62
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 14, 2020
314b49b gui: Fix regression in GUI console (Hennadii Stepanov) Pull request description: The regression was introduced in bitcoin#19056: if the GUI is running without `-server=1`, the `*txoutset*` call in the console returns "Shutting down". Fix bitcoin#19255. ACKs for top commit: ryanofsky: Code review ACK 314b49b. Only change since last review is rebase Tree-SHA512: 8ff85641a5c249858fecb1ab69c7a1b2850af651ff2a94aa41ce352b5b5bc95bc45c41e1767e871b51e647612d09e4d54ede3e20c313488afef5678826c51b62
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 10, 2020
Summary: ``` Make it interruptible, so that shutdown doesn't block for up to one hour. ``` Backport of core [[bitcoin/bitcoin#19056 | PR19056]] and [[bitcoin/bitcoin#19323 | PR19323]] (bugfix). Test Plan: ninja all check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8645
This was referenced Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it interruptible, so that shutdown doesn't block for up to one hour.
Fixes (partially) #13217