test: add factor option to adjust test timeouts #18617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Apr 13, 2020
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
Author
|
This one fails on travis, but succeeds on my macOS. Is there anything I could do to make it pass? mempool_reorg.py | ✖ Failed | 773 sError Log raise AssertionError("Mempool sync timed out:{}".format("".join("\n {!r}".format(m) for m in pool)))
AssertionError: Mempool sync timed out: |
This was referenced Apr 23, 2020
Member
|
Could you please bump the factor to 2.0 for the valgrind run and mark this pull as fixing #18834 ? |
Contributor
Author
Yes, sure, will do it. |
Co-authored-by: MarcoFalke <falke.marco@gmail.com>
Member
|
Thanks! ACK 2742c34 |
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 22, 2021
Summary: Co-authored-by: MarcoFalke <falke.marco@gmail.com> This PR adds a new option factor that can be used to adjust timeouts in various functional tests. Several timeouts and functions from authproxy, mininode, test_node and util have been adapted to use this option. The factor-option definition is located in test_framework.py. Fixes #18266 Also Fixes #18834 This is a backport of Core [[bitcoin/bitcoin#18617 | PR18617]] Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D9027
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new option factor that can be used to adjust timeouts in various functional tests.
Several timeouts and functions from
authproxy,mininode,test_nodeandutilhave been adapted to use this option. The factor-option definition is located intest_framework.py.Fixes #18266
Also Fixes #18834