cli: call getbalances.ismine.trusted instead of getwalletinfo.balance #18574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This change was ACKed in the original PR by @jonasschnelli. |
vasild
approved these changes
Apr 9, 2020
Contributor
vasild
left a comment
There was a problem hiding this comment.
utACK baa069151971f137782e3bd998f07f9f16185637
baa0691 to
7dd939a
Compare
Member
Author
|
Thanks for reviewing @vasild! Can you re-ACK? |
085d332 to
130abeb
Compare
Member
Author
|
Force-pushed for good catch by @vasild (thanks!) |
Contributor
|
ACK 130abeb93 Compiles and |
vasild
approved these changes
Apr 9, 2020
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
- no longer depend on the deprecated balance field of getwalletinfo - test blockcount and balance against non-default, non-zero expected values
130abeb to
5df0877
Compare
Member
Author
|
One (hopefully) last fixup 🤦 |
Contributor
|
ACK 5df0877
And thanks for updating the |
Member
|
ACK 5df0877 |
promag
reviewed
Apr 9, 2020
theStack
approved these changes
Apr 10, 2020
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 14, 2020
…ance Github-Pull: bitcoin#18574 Rebased-From: 7501977
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 14, 2020
- no longer depend on the deprecated balance field of getwalletinfo - test blockcount and balance against non-default, non-zero expected values Github-Pull: bitcoin#18574 Rebased-From: 5df0877
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 14, 2021
…ance Summary: > This PR updates bitcoin-cli -getinfo to fetch the wallet balance from getbalances in order to no longer depend on getwalletinfo.balance which was deprecated a year ago in D6447 > > test: update and harden interface_bitcoin_cli tests > > - no longer depend on the deprecated balance field of getwalletinfo > - test blockcount and balance against non-default, non-zero expected values This is a backport of Core [[bitcoin/bitcoin#18574 | PR18574]] Test Plan: `ninja all check-all` `src/bitcoin-cli -getinfo` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D8912
PhotoshiNakamoto
added a commit
to PhotonicBitcoin/pBTC-core
that referenced
this pull request
Dec 11, 2021
Bitcoin-Core PR: bitcoin/bitcoin#18574 Pull request description: Extracted from #18453 to preserve that PR as a discussion on multiwallet RPC/CLI. This PR updates `bitcoin-cli -getinfo` to fetch the wallet balance from `getbalances` in order to no longer depend on `getwalletinfo.balance` which was deprecated a year ago in facfb41. I found this when removing the getwalletinfo() `balance`, `unconfirmed_balance`, and `immature_balance` fields to see what broke from depending on them. I didn't see any perceivable change in `-getinfo` run time from the change. Test coverage for this change is provided by `test/functional/interface_bitcoin_cli.py`, which the second commit updates to (a) no longer depend on getwalletinfo.balances and (b) test the -getinfo blockcount and balance fields against non-default, non-zero values.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #18453 to preserve that PR as a discussion on multiwallet RPC/CLI.
This PR updates
bitcoin-cli -getinfoto fetch the wallet balance fromgetbalancesin order to no longer depend ongetwalletinfo.balancewhich was deprecated a year ago in facfb41.I found this when removing the getwalletinfo()
balance,unconfirmed_balance, andimmature_balancefields to see what broke from depending on them.I didn't see any perceivable change in
-getinforun time from the change.Test coverage for this change is provided by
test/functional/interface_bitcoin_cli.py, which the second commit updates to (a) no longer depend on getwalletinfo.balances and (b) test the -getinfo blockcount and balance fields against non-default, non-zero values.