Remove PID file at the very end #18526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
cvengler
suggested changes
Apr 6, 2020
Contributor
cvengler
left a comment
There was a problem hiding this comment.
Concept ACK with exception to move the done LogPrintf
b2486a3 to
7fcdec0
Compare
Member
Author
|
Updated b2486a3 -> 7fcdec0 (pr18526.01 -> pr18526.02, diff):
|
cvengler
approved these changes
Apr 6, 2020
Member
|
ACK 7fcdec0 |
promag
reviewed
Apr 9, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 13, 2020
7fcdec0 Remove PID file at the very end (Hennadii Stepanov) Pull request description: While reproducing the bug from bitcoin#18517, I've noticed that the `bitcoind.pid` file has already been removed when the `bitcoind` hangs. This PR makes `Shutdown()` keep the `bitcoind.pid` file available until the end. ACKs for top commit: MarcoFalke: ACK 7fcdec0 emilengler: utACK 7fcdec0 promag: Code review ACK 7fcdec0. theStack: Code review ACK 7fcdec0 Tree-SHA512: 9732ef34e137dbee70a06d922b316b8ea7b9a1c959cf8861b6940cd789336dc19ee468a4c3a28d95d1458076a48270c676b0ff27fec30cf57eced6ddab0a2a9b
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 14, 2021
Summary: > While reproducing the bug from #18517, I've noticed that the bitcoind.pid file has already been removed when the bitcoind hangs. > This PR makes Shutdown() keep the bitcoind.pid file available until the end. This is a backport of Core [[bitcoin/bitcoin#18526 | PR18526]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D8910
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reproducing the bug from #18517, I've noticed that the
bitcoind.pidfile has already been removed when thebitcoindhangs.This PR makes
Shutdown()keep thebitcoind.pidfile available until the end.