Skip to content

Conversation

@Empact
Copy link
Contributor

@Empact Empact commented Feb 28, 2020

Now that we're no longer special-casing clock usage for MacOS (see #17800), we're
not referencing anything defined in these headers.

Incidentally, this removes our last reference to the __MACH__ system def. 🎉

Now that we're no longer special-casing clock usage for MacOS, we're
not referencing anything defined in these headers.
@Empact
Copy link
Contributor Author

Empact commented Feb 28, 2020

/cc @fanquake sorry, I didn't look over #17800 until after it was merged.

@fanquake fanquake changed the title Drop unused MACH time headers random: drop unused MACH time headers Feb 29, 2020
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d361460 - thanks.

Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d361460

@fanquake fanquake merged commit 715dbbe into bitcoin:master Feb 29, 2020
@Empact Empact deleted the 2020-02-mach-headers branch February 29, 2020 10:33
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 29, 2020
d361460 Drop unused mach time headers (Ben Woosley)

Pull request description:

  Now that we're no longer special-casing clock usage for MacOS (see bitcoin#17800), we're
  not referencing anything defined in these headers.

  Incidentally, this removes our last reference to the `__MACH__` system def. 🎉

ACKs for top commit:
  jonasschnelli:
    utACK d361460
  fanquake:
    ACK d361460 - thanks.

Tree-SHA512: 246045b0683a705ad034416e8ace2024e652026a6c0517b6797320e52fc18a6e111ec2e405ca40653bd1d6421bb7755232e8fec22651fff8e448eb7d5646a954
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
d361460 Drop unused mach time headers (Ben Woosley)

Pull request description:

  Now that we're no longer special-casing clock usage for MacOS (see bitcoin#17800), we're
  not referencing anything defined in these headers.

  Incidentally, this removes our last reference to the `__MACH__` system def. 🎉

ACKs for top commit:
  jonasschnelli:
    utACK d361460
  fanquake:
    ACK d361460 - thanks.

Tree-SHA512: 246045b0683a705ad034416e8ace2024e652026a6c0517b6797320e52fc18a6e111ec2e405ca40653bd1d6421bb7755232e8fec22651fff8e448eb7d5646a954
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 4, 2021
Summary:
> Now that we're no longer special-casing clock usage for MacOS, we're
> not referencing anything defined in these headers.

This is a backport of Core [[bitcoin/bitcoin#18229 | PR18229]]

Depends on D8774

Test Plan:
`ninja all check-all`

@bot build-osx

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8776
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants