gui: Shortcut to close ModalOverlay #17998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4cb0dd to
1a638e1
Compare
Member
Contributor
|
ACK, why not? I know I've tried several times to close with ESC.. |
jonasschnelli
added a commit
that referenced
this pull request
Jan 27, 2020
1a638e1 gui: Shortcut to close ModalOverlay (Emil Engler) Pull request description: This adds the shortcut `Esc` to hide the ModalOverlay. The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain. ACKs for top commit: kristapsk: ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here. jonasschnelli: ACK 1a638e1 Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 27, 2020
1a638e1 gui: Shortcut to close ModalOverlay (Emil Engler) Pull request description: This adds the shortcut `Esc` to hide the ModalOverlay. The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain. ACKs for top commit: kristapsk: ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here. jonasschnelli: ACK 1a638e1 Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Feb 9, 2020
Github-Pull: bitcoin#17998 Rebased-From: 1a638e1
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 6, 2020
- gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged bitcoin#18160 - gui: Drop PeerTableModel dependency to ClientModel bitcoin#18060 - gui: Break trivial circular dependencies bitcoin#18036 - gui: Improve "Hide" button tool-tip message bitcoin#17360 - gui: Shortcut to close ModalOverlay bitcoin#17998 - gui: Remove warning "unused variable 'wallet_model'" bitcoin#17939 - refactor: Use PACKAGE_NAME in GUI modal overlay and bitcoin-wallet bitcoin#17923 - gui: remove OpenSSL PRNG seeding (Windows, Qt only) bitcoin#17151 - refactor: Remove unused defines in qt/bitcoinunits.h bitcoin#17869
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
1a638e1 gui: Shortcut to close ModalOverlay (Emil Engler) Pull request description: This adds the shortcut `Esc` to hide the ModalOverlay. The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain. ACKs for top commit: kristapsk: ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here. jonasschnelli: ACK 1a638e1 Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 18, 2020
Summary: Set a shortcut to close the modal overlay in bitcoin-qt with the Esc key. The rationale is that it makes testing easier, when you need to start the application multiple times in a row. This is a backport of Core [[bitcoin/bitcoin#17998 | PR17998]] Test Plan: `ninja && src/qt/bitcoin-qt` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8689
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
1a638e1 gui: Shortcut to close ModalOverlay (Emil Engler) Pull request description: This adds the shortcut `Esc` to hide the ModalOverlay. The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain. ACKs for top commit: kristapsk: ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here. jonasschnelli: ACK 1a638e1 Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
1a638e1 gui: Shortcut to close ModalOverlay (Emil Engler) Pull request description: This adds the shortcut `Esc` to hide the ModalOverlay. The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain. ACKs for top commit: kristapsk: ACK 1a638e1. Agree with @promag, Esc feels more natural than Enter here. jonasschnelli: ACK 1a638e1 Tree-SHA512: ea764349ec145ce9a34cbc66c3ac0eace9233a3fb3e9c22694a77882478afa22d4e686ce2c1d7b3938f6769f96ba995577b0216ba9d98954dcf3e55d2187f2e0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the shortcut
Escto hide the ModalOverlay.The motivation is that it is annoying to always move the cursor to "Hide" when quickly testing something in the GUI with an outdated chain.