Skip to content

ci: Run tests on arm #17041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fanquake merged 1 commit into from
Oct 9, 2019
Merged

ci: Run tests on arm #17041

fanquake merged 1 commit into from
Oct 9, 2019

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Oct 3, 2019

Closes #16576

@practicalswift
Copy link
Contributor

practicalswift commented Oct 3, 2019

Concept ACK

Thanks for working on this -- diversity in testing is good!

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 3, 2019 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@maflcko maflcko force-pushed the 1909-ciFunArm branch 6 times, most recently from f3d835c to 9999e92 Compare October 3, 2019 23:27
@DrahtBot DrahtBot added the Tests label Oct 4, 2019
@maflcko
Copy link
Member Author

maflcko commented Oct 4, 2019

Idk, giving up here. I can't make any sense of why travis fails here.

@maflcko maflcko force-pushed the 1909-ciFunArm branch 6 times, most recently from d560b29 to faebfba Compare October 8, 2019 14:56
@maflcko maflcko force-pushed the 1909-ciFunArm branch 4 times, most recently from faac5a7 to fabfd26 Compare October 8, 2019 17:39
@hebasto
Copy link
Member

hebasto commented Oct 8, 2019

Concept ACK.

@maflcko maflcko force-pushed the 1909-ciFunArm branch 2 times, most recently from c880d2f to fa852be Compare October 8, 2019 19:26
@maflcko
Copy link
Member Author

maflcko commented Oct 8, 2019

Squashed. Travis should pass now 🙏

@laanwj
Copy link
Member

laanwj commented Oct 9, 2019 •
edited
Loading

ACK fa852be6f5763ccb7c6f36ef7be61d0ac7ad5454
ACK fa79dff

@laanwj
Copy link
Member

laanwj commented Oct 9, 2019

But please change the name of the travis run, that unit tests are run now:

    - stage: test
      name: 'ARM  [GOAL: install]  [no unit or functional tests]'
      env: >-
        FILE_ENV="./ci/test/00_setup_env_arm.sh"

@Empact
Copy link
Contributor

Empact commented Oct 9, 2019

ACK fa852be modulo #17041 (comment)

@maflcko
Copy link
Member Author

maflcko commented Oct 9, 2019

But please change the name of the travis run, that unit tests are run now:

Good catch. Fixed the travis.yml build names.

fanquake
fanquake approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa79dff - assuming Travis is green again.

fanquake added a commit that referenced this pull request Oct 9, 2019
@fanquake
Merge #17041: ci: Run tests on arm
1c11e53 
fa79dff ci: Run tests on arm (MarcoFalke)

Pull request description:

  Closes #16576

ACKs for top commit:
  laanwj:
    ACK fa79dff
  fanquake:
    ACK fa79dff - assuming Travis is green again.

Tree-SHA512: c430db9852632567c6836981fb3c5922ccd7d3b6ab4a1c6405ffad75096b80433ba54785ffa4c5088c1a127689a945f0f86058a42de1d3efea3cc4967832d662
@fanquake fanquake merged commit fa79dff into bitcoin:master Oct 9, 2019
@maflcko maflcko deleted the 1909-ciFunArm branch October 9, 2019 14:36
@maflcko maflcko mentioned this pull request Oct 9, 2019
Merged
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 9, 2019
@fanquake
Merge bitcoin#17041: ci: Run tests on arm
a779ca1 
fa79dff ci: Run tests on arm (MarcoFalke)

Pull request description:

  Closes bitcoin#16576

ACKs for top commit:
  laanwj:
    ACK fa79dff
  fanquake:
    ACK fa79dff - assuming Travis is green again.

Tree-SHA512: c430db9852632567c6836981fb3c5922ccd7d3b6ab4a1c6405ffad75096b80433ba54785ffa4c5088c1a127689a945f0f86058a42de1d3efea3cc4967832d662
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 9, 2019
Revert "Merge bitcoin#17041: ci: Run tests on arm"
a3c7135 
This reverts commit a779ca1.
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
@sipa
Copy link
Member

sipa commented Mar 8, 2021

@KaycoinsInc Please stop spamming this repository.

kwvg added a commit to kwvg/dash that referenced this pull request Feb 12, 2022
@kwvg
merge bitcoin#17041: Run tests on arm
275716c
@kwvg kwvg mentioned this pull request Feb 12, 2022
Merged
kwvg added a commit to kwvg/dash that referenced this pull request Nov 7, 2022
@kwvg
merge bitcoin#17041: Run tests on arm
1b7b516
@bitcoin bitcoin locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake approved these changes

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[help needed] Add notes on how to run unit and functional tests in QEMU

8 participants

@maflcko @practicalswift @DrahtBot @hebasto @laanwj @Empact @sipa @fanquake