Skip to content

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Sep 26, 2019

This part of the build system has been removed in #15529 and thus no longer needs to be updated.

This part of the build system has been removed in bitcoin#15529 and thus no
longer needs to be updated.
@laanwj laanwj added the Docs label Sep 26, 2019
@maflcko
Copy link
Member

maflcko commented Sep 26, 2019

ACK 8d841ad

Looks like this has been replaced by a wildcard

build_msvc/libbitcoin_qt/libbitcoin_qt.vcxproj:    <TranslationFiles Include="..\..\src\qt\locale\*.ts" />

cc @sipsorcery

@sipsorcery
Copy link
Contributor

ACK 8d841ad

The two msvc qt projects could not be built without a lot of effort (which I highly doubt anyone did) prior to #15529.

@cvengler
Copy link
Contributor

ACK

laanwj added a commit that referenced this pull request Sep 26, 2019
8d841ad doc: Remove MSVC update step from translation process (Wladimir J. van der Laan)

Pull request description:

  This part of the build system has been removed in #15529 and thus no longer needs to be updated.

ACKs for top commit:
  MarcoFalke:
    ACK 8d841ad
  sipsorcery:
    ACK 8d841ad

Tree-SHA512: f561a6b1da806e8868a265c77725b94fabef60bc7b9d401e3f70c3d859323adc2e204e3d6fbfea4f1ff86e70667f8bd01157411106ea93974921c02d874e0083
@laanwj laanwj merged commit 8d841ad into bitcoin:master Sep 26, 2019
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Sep 26, 2019
…ocess

8d841ad doc: Remove MSVC update step from translation process (Wladimir J. van der Laan)

Pull request description:

  This part of the build system has been removed in bitcoin#15529 and thus no longer needs to be updated.

ACKs for top commit:
  MarcoFalke:
    ACK 8d841ad
  sipsorcery:
    ACK 8d841ad

Tree-SHA512: f561a6b1da806e8868a265c77725b94fabef60bc7b9d401e3f70c3d859323adc2e204e3d6fbfea4f1ff86e70667f8bd01157411106ea93974921c02d874e0083
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants