refactor: move LoadChainTip/RelayBlocks under CChainState #16743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
ryanofsky
approved these changes
Aug 29, 2019
Contributor
ryanofsky
left a comment
There was a problem hiding this comment.
utACK 70e969495191a89070a1308393a5749b37b11e8d
promag
reviewed
Aug 30, 2019
src/validation.cpp
Outdated
Contributor
There was a problem hiding this comment.
70e969495191a89070a1308393a5749b37b11e8d
this-> 👀
Contributor
Author
There was a problem hiding this comment.
Hah yeah, I guess we have yet to formalize anything around this but I prefer prefixing method calls with this-> for clarity. See the related IRC discussion.
Contributor
There was a problem hiding this comment.
re: #16743 (comment)
At some point I tried to allow lowerCase() for object methods as way to distinguish calls that use the current object from calls that don't (#14635), but agree that this-> helps without that option.
70e9694 to
d5ec57c
Compare
Contributor
Author
|
Thanks for the reviews so far. Have addressed feedback from @ryanofsky, @promag. |
Member
|
Code review ACK d5ec57c, modulo (documentation) rebase. |
d5ec57c to
3cf3673
Compare
ryanofsky
approved these changes
Sep 19, 2019
src/validation.cpp
Outdated
Contributor
There was a problem hiding this comment.
re: #16743 (comment)
At some point I tried to allow lowerCase() for object methods as way to distinguish calls that use the current object from calls that don't (#14635), but agree that this-> helps without that option.
Member
|
ACK 3cf3673 Show signature and timestampSignature: Timestamp of file with hash |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Sep 19, 2019
…hainState 3cf3673 refactoring: move ReplayBlocks under CChainState (James O'Beirne) bcf73d3 refactoring: move LoadChainTip to CChainState method (James O'Beirne) f5809d5 doc: fix CChainState::ActivateBestChain doc (James O'Beirne) Pull request description: This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11): Parent PR: bitcoin#15606 Issue: bitcoin#15605 Specification: https://github.com/jamesob/assumeutxo-docs/tree/master/proposal --- Move more chainstate-related functionality to methods on CChainState. Nothing too interesting here, but needed to work with multiple chainstates. And brief to review. :) Also fixes doc on ActivateBestChain. ACKs for top commit: MarcoFalke: ACK 3cf3673 ryanofsky: Can confirm. utACK 3cf3673. Removes wrapper functions and removes more ::ChainActive() and ::ChainstateActive() calls than it adds, so seems good. Tree-SHA512: 4bf8a1dd454ca9d61c85f6736910fa7354c57acc0002e3a8e5ce494035d8280e4c20e066f03478eeff7d44195e7912c282a486526da9be53854b478b961affaa
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 23, 2019
…hainState 3cf3673 refactoring: move ReplayBlocks under CChainState (James O'Beirne) bcf73d3 refactoring: move LoadChainTip to CChainState method (James O'Beirne) f5809d5 doc: fix CChainState::ActivateBestChain doc (James O'Beirne) Pull request description: This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11): Parent PR: bitcoin#15606 Issue: bitcoin#15605 Specification: https://github.com/jamesob/assumeutxo-docs/tree/master/proposal --- Move more chainstate-related functionality to methods on CChainState. Nothing too interesting here, but needed to work with multiple chainstates. And brief to review. :) Also fixes doc on ActivateBestChain. ACKs for top commit: MarcoFalke: ACK 3cf3673 ryanofsky: Can confirm. utACK 3cf3673. Removes wrapper functions and removes more ::ChainActive() and ::ChainstateActive() calls than it adds, so seems good. Tree-SHA512: 4bf8a1dd454ca9d61c85f6736910fa7354c57acc0002e3a8e5ce494035d8280e4c20e066f03478eeff7d44195e7912c282a486526da9be53854b478b961affaa
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 16, 2020
…State Summary: 3cf36736e540cf06250701f0934a7946836d000d refactoring: move ReplayBlocks under CChainState (James O'Beirne) bcf73d3b84649c8786f0cccc6862dd1bbdb9950b refactoring: move LoadChainTip to CChainState method (James O'Beirne) f5809d5b135c7f9de5217d3cda76638fe7eed58a doc: fix CChainState::ActivateBestChain doc (James O'Beirne) Pull request description: This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11): Parent PR: #15606 Issue: #15605 Specification: https://github.com/jamesob/assumeutxo-docs/tree/master/proposal --- Move more chainstate-related functionality to methods on CChainState. Nothing too interesting here, but needed to work with multiple chainstates. And brief to review. :) Also fixes doc on ActivateBestChain. ACKs for top commit: MarcoFalke: ACK 3cf36736e540cf06250701f0934a7946836d000d ryanofsky: Can confirm. utACK 3cf36736e540cf06250701f0934a7946836d000d. Removes wrapper functions and removes more ::ChainActive() and ::ChainstateActive() calls than it adds, so seems good. --- Backport of Core [[bitcoin/bitcoin#16743 | PR16743]] Test Plan: ninja all check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7960
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Oct 22, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the assumeutxo project:
Parent PR: #15606
Issue: #15605
Specification: https://github.com/jamesob/assumeutxo-docs/tree/master/proposal
Move more chainstate-related functionality to methods on CChainState. Nothing too interesting here, but needed to work with multiple chainstates. And brief to review. :)
Also fixes doc on ActivateBestChain.