net: Restore default whitelistrelay to true #16631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
approved these changes
Aug 16, 2019
Contributor
Author
|
Is there something strange with travis? all PRs seems not passing. |
2433fc1 to
59542e8
Compare
maflcko
reviewed
Aug 16, 2019
maflcko
reviewed
Aug 16, 2019
Contributor
|
NACK sorry, I think removing args shouldn't be done instantly. They should go through a depraction process and be removed after one major version has been released. Otherwise it could break compatibility. |
Contributor
Author
|
@emilengler this PR is precisely about restoring compatibility that I broke during previous PR. |
59542e8 to
2e35132
Compare
Contributor
|
Concept ACK |
Contributor
Author
|
As @MarcoFalke suggested, I moved I also reformatted the |
Member
|
ACK 2e35132, modulo missing
Yes, one more rebase should make that go away, see #16633. |
2e35132 to
751b28b
Compare
Contributor
Author
|
@Sjors oops, fixed the chmod, sorry for that. |
751b28b to
df0d847
Compare
Contributor
Author
|
|
df0d847 to
3b05f0f
Compare
Contributor
Author
|
I rebased and also fixed |
Contributor
|
ACK 3b05f0f. nit, could split the moved code to a move-only commit. |
Member
|
re-ACK 3b05f0f |
Member
|
ACK 3b05f0f |
laanwj
added a commit
that referenced
this pull request
Aug 19, 2019
3b05f0f Reformat p2p_permissions.py (nicolas.dorier) ce7eac3 [Fix] The default whitelistrelay should be true (nicolas.dorier) Pull request description: I thought `whitelistrelay` default was `false` when it is `true`. The root of the issue come from the fact that all references to `DEFAULT_` are not in the scope of this file, so hard coding of default values are used everywhere in `net.cpp`. I think that in a separate PR we should fix that more fundamentally everywhere. ACKs for top commit: promag: ACK 3b05f0f. Sjors: re-ACK 3b05f0f Tree-SHA512: f4a75f986fa2adf1a5f1c91605e0d261f7ac5ac8535fb05437d83b8392dbcf5cc1a47d755adcf8ad8dc67a88de28060187200fd3ce06545261a5c7ec0fea831a
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 19, 2019
3b05f0f Reformat p2p_permissions.py (nicolas.dorier) ce7eac3 [Fix] The default whitelistrelay should be true (nicolas.dorier) Pull request description: I thought `whitelistrelay` default was `false` when it is `true`. The root of the issue come from the fact that all references to `DEFAULT_` are not in the scope of this file, so hard coding of default values are used everywhere in `net.cpp`. I think that in a separate PR we should fix that more fundamentally everywhere. ACKs for top commit: promag: ACK 3b05f0f. Sjors: re-ACK 3b05f0f Tree-SHA512: f4a75f986fa2adf1a5f1c91605e0d261f7ac5ac8535fb05437d83b8392dbcf5cc1a47d755adcf8ad8dc67a88de28060187200fd3ce06545261a5c7ec0fea831a
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Sep 3, 2019
Github-Pull: bitcoin#16631 Rebased-From: ce7eac3
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Sep 3, 2019
Github-Pull: bitcoin#16631 Rebased-From: 3b05f0f
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
May 2, 2020
Summary: This is a backport of Core [[bitcoin/bitcoin#16631 | PR16631]] Test Plan: ninja all check-all Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D5940
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 20, 2021
3b05f0f Reformat p2p_permissions.py (nicolas.dorier) ce7eac3 [Fix] The default whitelistrelay should be true (nicolas.dorier) Pull request description: I thought `whitelistrelay` default was `false` when it is `true`. The root of the issue come from the fact that all references to `DEFAULT_` are not in the scope of this file, so hard coding of default values are used everywhere in `net.cpp`. I think that in a separate PR we should fix that more fundamentally everywhere. ACKs for top commit: promag: ACK 3b05f0f. Sjors: re-ACK 3b05f0f Tree-SHA512: f4a75f986fa2adf1a5f1c91605e0d261f7ac5ac8535fb05437d83b8392dbcf5cc1a47d755adcf8ad8dc67a88de28060187200fd3ce06545261a5c7ec0fea831a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought
whitelistrelaydefault wasfalsewhen it istrue.The root of the issue come from the fact that all references to
DEFAULT_are not in the scope of this file, so hard coding of default values are used everywhere innet.cpp. I think that in a separate PR we should fix that more fundamentally everywhere.