-
Notifications
You must be signed in to change notification settings - Fork 38.7k
doc: add reduce-memory.md #16339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add reduce-memory.md #16339
Conversation
babbd99 to
341e5a6
Compare
hebasto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach ACK 341e5a673a9dd3ef9d225e49362a600d7bd4f213
|
utACK 341e5a673a9dd3ef9d225e49362a600d7bd4f213 modulo @hebasto's nits :-) |
|
Shouldn't this be linked to from |
Co-Authored-By: Wladimir J. van der Laan <laanwj@gmail.com>
341e5a6 to
64b27c4
Compare
|
Have removed the old version mentions, as well as fixed some styling and wording.
Added a link from |
|
ACK 64b27c4 |
|
ACK 64b27c4, I have reviewed the changes and they look OK, I agree they can be merged. Also a link from |
promag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice ACK, just had a quick look and also didn't confirm since x.x.x versions - not sure if it's relevant here.
|
Good idea! |
64b27c4 docs: add reduce-memory.md (fanquake) Pull request description: Following some discussion in bitcoin-core/docs#50, this adds Wladimir's [reducing bitcoind memory usage gist](https://gist.github.com/laanwj/efe29c7661ce9b6620a7) to `/doc`. The conclusion seemed to be that if the main repo already has [reduce-traffic.md](https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-traffic.md), then we could also add `reduce-memory.md`. ACKs for top commit: practicalswift: ACK 64b27c4 hebasto: ACK 64b27c4, I have reviewed the changes and they look OK, I agree they can be merged. Also a link from `/doc/README.md` has been tested. jonasschnelli: ACK 64b27c4 Tree-SHA512: 0ab3035403e5145cfe33c29990a8d082df834ac6602b4ad6bfa821523d57e8451f0cde3017fbf3c2c4e0b34941b6374909d11d27f9598e211bbc14accd487be1
Summary: Add a documentation page on keeping memory usage low when running bitcoind Co-Authored-By: Wladimir J. van der Laan <laanwj@gmail.com> Backport of Core [[bitcoin/bitcoin#16339 | PR16339]] Test Plan: Proof-reading in a markdown viewer. Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7847
caa6734 docs: add reduce-memory.md (fanquake) Pull request description: There are a few parameters that can be dialed down to reduce the memory usage of `pivxd`. This can be useful on embedded systems or small VPSes. Back ported + adapted `reduce-memory.md` document created in bitcoin#16339. ACKs for top commit: Fuzzbawls: utACK caa6734 random-zebra: utACK caa6734 and merging... Tree-SHA512: 54b6cf1be321e73a0477bb7bd8c02c61d4af524ac8275be28c609bd2ce89656ed323fdf9345e8a03ce9e9187d0e8332c21f65f562b3942046811b49c6aa3b67f
64b27c4 docs: add reduce-memory.md (fanquake) Pull request description: Following some discussion in bitcoin-core/docs#50, this adds Wladimir's [reducing bitcoind memory usage gist](https://gist.github.com/laanwj/efe29c7661ce9b6620a7) to `/doc`. The conclusion seemed to be that if the main repo already has [reduce-traffic.md](https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-traffic.md), then we could also add `reduce-memory.md`. ACKs for top commit: practicalswift: ACK 64b27c4 hebasto: ACK 64b27c4, I have reviewed the changes and they look OK, I agree they can be merged. Also a link from `/doc/README.md` has been tested. jonasschnelli: ACK 64b27c4 Tree-SHA512: 0ab3035403e5145cfe33c29990a8d082df834ac6602b4ad6bfa821523d57e8451f0cde3017fbf3c2c4e0b34941b6374909d11d27f9598e211bbc14accd487be1
ikeedge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M
Following some discussion in bitcoin-core/docs#50, this adds Wladimir's reducing bitcoind memory usage gist to
/doc.The conclusion seemed to be that if the main repo already has reduce-traffic.md, then we could also add
reduce-memory.md.