Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jul 5, 2019

Following some discussion in bitcoin-core/docs#50, this adds Wladimir's reducing bitcoind memory usage gist to /doc.

The conclusion seemed to be that if the main repo already has reduce-traffic.md, then we could also add reduce-memory.md.

@fanquake fanquake added the Docs label Jul 5, 2019
@fanquake fanquake force-pushed the doc-reduce-memory-usage branch from babbd99 to 341e5a6 Compare July 5, 2019 02:22
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK 341e5a673a9dd3ef9d225e49362a600d7bd4f213

@practicalswift
Copy link
Contributor

utACK 341e5a673a9dd3ef9d225e49362a600d7bd4f213 modulo @hebasto's nits :-)

@flack
Copy link
Contributor

flack commented Jul 5, 2019

Shouldn't this be linked to from README.md?

Co-Authored-By: Wladimir J. van der Laan <laanwj@gmail.com>
@fanquake fanquake force-pushed the doc-reduce-memory-usage branch from 341e5a6 to 64b27c4 Compare July 6, 2019 02:45
@fanquake
Copy link
Member Author

fanquake commented Jul 6, 2019

Have removed the old version mentions, as well as fixed some styling and wording.

Shouldn't this be linked to from README.md?

Added a link from /doc/README.md

@practicalswift
Copy link
Contributor

practicalswift commented Jul 6, 2019

ACK 64b27c4

@hebasto
Copy link
Member

hebasto commented Jul 6, 2019

ACK 64b27c4, I have reviewed the changes and they look OK, I agree they can be merged. Also a link from /doc/README.md has been tested.

Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice ACK, just had a quick look and also didn't confirm since x.x.x versions - not sure if it's relevant here.

@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jul 7, 2019

Good idea!
ACK 64b27c4

@fanquake fanquake merged commit 64b27c4 into bitcoin:master Jul 8, 2019
fanquake added a commit that referenced this pull request Jul 8, 2019
64b27c4 docs: add reduce-memory.md (fanquake)

Pull request description:

  Following some discussion in bitcoin-core/docs#50, this adds Wladimir's [reducing bitcoind memory usage gist](https://gist.github.com/laanwj/efe29c7661ce9b6620a7) to `/doc`.

  The conclusion seemed to be that if the main repo already has [reduce-traffic.md](https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-traffic.md), then we could also add `reduce-memory.md`.

ACKs for top commit:
  practicalswift:
    ACK 64b27c4
  hebasto:
    ACK 64b27c4, I have reviewed the changes and they look OK, I agree they can be merged. Also a link from `/doc/README.md` has been tested.
  jonasschnelli:
    ACK 64b27c4

Tree-SHA512: 0ab3035403e5145cfe33c29990a8d082df834ac6602b4ad6bfa821523d57e8451f0cde3017fbf3c2c4e0b34941b6374909d11d27f9598e211bbc14accd487be1
@fanquake fanquake deleted the doc-reduce-memory-usage branch July 8, 2019 00:36
@jnewbery
Copy link
Contributor

jnewbery commented Jul 8, 2019

ACK 64b27c4

Thanks @laanwj and @fanquake for adding this.

jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 9, 2020
Summary:
Add a documentation page on keeping memory usage low when running bitcoind

Co-Authored-By: Wladimir J. van der Laan <laanwj@gmail.com>

Backport of Core  [[bitcoin/bitcoin#16339 | PR16339]]

Test Plan: Proof-reading in a markdown viewer.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D7847
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request Mar 24, 2021
caa6734 docs: add reduce-memory.md (fanquake)

Pull request description:

  There are a few parameters that can be dialed down to reduce the memory usage of `pivxd`. This can be useful on embedded systems or small VPSes.

  Back ported + adapted `reduce-memory.md` document created in bitcoin#16339.

ACKs for top commit:
  Fuzzbawls:
    utACK caa6734
  random-zebra:
    utACK caa6734 and merging...

Tree-SHA512: 54b6cf1be321e73a0477bb7bd8c02c61d4af524ac8275be28c609bd2ce89656ed323fdf9345e8a03ce9e9187d0e8332c21f65f562b3942046811b49c6aa3b67f
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
64b27c4 docs: add reduce-memory.md (fanquake)

Pull request description:

  Following some discussion in bitcoin-core/docs#50, this adds Wladimir's [reducing bitcoind memory usage gist](https://gist.github.com/laanwj/efe29c7661ce9b6620a7) to `/doc`.

  The conclusion seemed to be that if the main repo already has [reduce-traffic.md](https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-traffic.md), then we could also add `reduce-memory.md`.

ACKs for top commit:
  practicalswift:
    ACK 64b27c4
  hebasto:
    ACK 64b27c4, I have reviewed the changes and they look OK, I agree they can be merged. Also a link from `/doc/README.md` has been tested.
  jonasschnelli:
    ACK 64b27c4

Tree-SHA512: 0ab3035403e5145cfe33c29990a8d082df834ac6602b4ad6bfa821523d57e8451f0cde3017fbf3c2c4e0b34941b6374909d11d27f9598e211bbc14accd487be1
Copy link

@ikeedge ikeedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M

@bitcoin bitcoin locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants