Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options#15913
Merged
maflcko merged 2 commits intobitcoin:masterfrom Apr 29, 2019
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
utACK 765d589 |
Member
|
utACK 765d589 Show signature@luke-jr See maflcko@fac174e for a linter fixup |
Contributor
|
utACK 765d589. |
Contributor
|
utACK 765d589 Good idea with a linter guarding against this happening in the future. |
Member
|
utACK 765d589 |
maflcko
pushed a commit
that referenced
this pull request
Apr 29, 2019
…f ignored wallet options 765d589 Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (Luke Dashjr) 0f09eb7 dummywallet: Reformat ignored wallet options list (Luke Dashjr) Pull request description: When building w/o wallet support, we add all the wallet options as hidden options to avoid throwing errors/warnings that they're unknown. `-ignorepartialspends` is missing from this list. This PR adds it. (This seems like a good candidate for a linter? Or maybe we can autogenerate it?) Also reformats the dummywallet options list across multiple lines to make conflicts less often. ACKs for commit 765d58: meshcollider: utACK 765d589 MarcoFalke: utACK 765d589 promag: utACK 765d589. practicalswift: utACK 765d589 fanquake: utACK 765d589 Tree-SHA512: 37c8037148bdc1b7a8bde201eff51ee6a64c042c17eb8b6c68faef490d16575348c2f22ab81f48302b8ad80a5559222af23b721a8b5acc1d89c0757fb88796a6
Member
Author
|
Probably should tag this for backport to 0.18.1 |
Member
Thanks, that was indeed leading to frequent rebase needs for me in #14145. Post merge utACK |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jun 11, 2019
…et options Github-Pull: bitcoin#15913 Rebased-From: 765d589
Contributor
|
For the record, this adds -avoidpartialspends to the ignored list. |
laanwj
added a commit
that referenced
this pull request
Jun 13, 2019
…ored wallet options" 106471d Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (Luke Dashjr) 206c30f dummywallet: Reformat ignored wallet options list (MarcoFalke) Pull request description: First run clang-format on the wallet options list (review with `--word-diff-regex=.`). This is not a backport. Then backport Github-Pull: #15913 ACKs for commit 106471: promag: ACK 106471d. laanwj: ACK 106471d Tree-SHA512: 3e6eb7997aa32ef7385842614bac8cac56f86b6dde949cfbbd33b4387e713bf5f65e40ee3e4228ac43dfe50829169175b80ddeaac8a714ad8a38175638123f5d
uhliksk
pushed a commit
to fxtc/fxtc
that referenced
this pull request
Jun 28, 2019
…et options Github-Pull: bitcoin#15913 Rebased-From: 765d589
uhliksk
pushed a commit
to fxtc/fxtc
that referenced
this pull request
Aug 6, 2019
…et options Github-Pull: bitcoin#15913 Rebased-From: 765d589
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
…et options Github-Pull: bitcoin#15913 Rebased-From: 765d589
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
…et options Github-Pull: bitcoin#15913 Rebased-From: 765d589
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 28, 2021
… list of ignored wallet options 765d589 Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (Luke Dashjr) 0f09eb7 dummywallet: Reformat ignored wallet options list (Luke Dashjr) Pull request description: When building w/o wallet support, we add all the wallet options as hidden options to avoid throwing errors/warnings that they're unknown. `-ignorepartialspends` is missing from this list. This PR adds it. (This seems like a good candidate for a linter? Or maybe we can autogenerate it?) Also reformats the dummywallet options list across multiple lines to make conflicts less often. ACKs for commit 765d58: meshcollider: utACK bitcoin@765d589 MarcoFalke: utACK 765d589 promag: utACK 765d589. practicalswift: utACK 765d589 fanquake: utACK 765d589 Tree-SHA512: 37c8037148bdc1b7a8bde201eff51ee6a64c042c17eb8b6c68faef490d16575348c2f22ab81f48302b8ad80a5559222af23b721a8b5acc1d89c0757fb88796a6 Signed-off-by: pasta <pasta@dashboost.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building w/o wallet support, we add all the wallet options as hidden options to avoid throwing errors/warnings that they're unknown.
-ignorepartialspendsis missing from this list. This PR adds it.(This seems like a good candidate for a linter? Or maybe we can autogenerate it?)
Also reformats the dummywallet options list across multiple lines to make conflicts less often.