0.18: rc3 backports #15691
Merged
0.18: rc3 backports #15691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#15644 Rebased-From: 9453018
Github-Pull: bitcoin#15644 Rebased-From: 6e051f3
This makes orphan processing work like handling getdata messages: After every actual transaction validation attempt, interrupt processing to deal with messages arriving from other peers. Github-Pull: bitcoin#15644 Rebased-From: 866c805
Contributor
|
ACK |
The existing wallet_resendwallettransactions.py test only tests the resendwallettransactions RPC. It does not test whether transactions are actually rebroadcast, or whether the rebroadcast logic is called on a timer. This commit updates the test to not use the resendwallettransactions RPC and test that transactions are rebroadcast on a timer. Github-Pull: bitcoin#15646 Rebased-From: 529c1ae
Github-Pull: bitcoin#15652 Rebased-From: 0440481
Github-Pull: bitcoin#15652 Rebased-From: 57908a7
Github-Pull: bitcoin#15652 Rebased-From: 2ebf650
Github-Pull: bitcoin#15652 Rebased-From: 4bf1b1c
Member
Author
|
Would be nice if someone could double check the cherry-picks for correctly solving the conflicts |
Contributor
Member
|
utACK 95faffe |
laanwj
added a commit
that referenced
this pull request
Apr 2, 2019
95faffe qa: Check unconfirmed balance after loadwallet (João Barbosa) 59716ec wallet: Update transactions with current mempool after load (João Barbosa) ed0498a interfaces: Add Chain::requestMempoolTransactions (João Barbosa) ebf6566 wallet: Move CWallet::ReacceptWalletTransactions locks to callers (João Barbosa) a90db2f [tests] Add test for wallet rebroadcasts (John Newbery) 50c56f2 Interrupt orphan processing after every transaction (Pieter Wuille) bb60121 [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx (Pieter Wuille) 6355214 Simplify orphan processing in preparation for interruptibility (Pieter Wuille) Pull request description: Remaining backports for rc3 ACKs for commit 95faff: promag: ACK 95faffe, well done in ed0498a - verified all cherry picks. Tree-SHA512: 597ee45493ac04e8c3149628a357c3238169d4b4f78158f22a3531e5f66289c228ecd6582f99026698883216f1ee7934d6315d19c99fc5f4f33dd1bed4300186
This was referenced Apr 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining backports for rc3