change default Python block serialization to witness #15664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
reviewed
Mar 26, 2019
c671587 to
f70d0cd
Compare
jnewbery
reviewed
Mar 26, 2019
Contributor
jnewbery
left a comment
There was a problem hiding this comment.
Concept ACK moving to segwit being the default for the test framework.
Your additional code in mining_basic is testing that the test framework can deserialize and then serialize a block (ie block_hex = serialize(deserialize(block_hex))). I don't think tests of the test framework belong in the individual test cases. Those are supposed to be testing the node.
I'd just drop the changes to mining_basic.py.
Member
Author
|
@jnewbery do we have a place to self-test python serialization/utility code? I've added this before to other tests. I can drop it here for now. |
Contributor
We don't. I don't think it's worth it to be honest. The python code is pretty simple. If we did add it, I'd suggest adding it to |
maflcko
reviewed
Mar 27, 2019
test/functional/mining_basic.py
Outdated
Member
There was a problem hiding this comment.
Suggested change
| assert(block.serialize(with_witness=False).hex() != block_hex) | |
| assert block.serialize(with_witness=False).hex() != block_hex |
f70d0cd to
124ea38
Compare
Member
Author
|
removed round-trip test |
Contributor
|
ACK 124ea38 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 8, 2019
Unnamed arguments are confusing as to what they mean without looking up the function signature. Since segwit is active by default in regtest, and all blocks are serialized with witness (bitcoin#15664, c459c5f), remove the argument `with_witness=True` from all calls to `CBlock::serialize` and `BlockTransactions::serialize`. This diff has been created with a script, but is better reviewed without a scripted diff. sed -i --regexp-extended -e 's/block(_?[2a-z]*)\.serialize\([a-z_]*=?True/block\1.serialize(/g' $(git grep -l serialize ./test)
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 8, 2019
…ness 124ea38 change default Python block serialization to witness (Gregory Sanders) Pull request description: ACKs for commit 124ea3: stevenroose: ACK 124ea38 Tree-SHA512: 52877934f8a3c761cb89a618daffe73e86b008d9d32d48721392b7626aaa10d3b9aa26e4c59337729e0a2d01fc48648eef5ec3d72de531a685a2cf4f4d7579ab
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jun 17, 2019
fa1d766 tests: Make msg_block a witness block (MarcoFalke) fa52eb5 test: Remove True argument to CBlock::serialize (MarcoFalke) Pull request description: Unnamed arguments are confusing as to what they mean without looking up the function signature. Since segwit is active by default in regtest, and all blocks are serialized with witness (bitcoin#15664), remove the argument `with_witness=True` from all calls to `CBlock::serialize` and `BlockTransactions::serialize`. ACKs for commit fa1d76: laanwj: code-review ACK fa1d766 Tree-SHA512: 2c550646f99c9ca86a223ca988c61a730f5e6646807adeaa7174fb2424a32cea3fef8bcd3e0b12e162e7ff192877d0c02fd0654df6ee1a9b821b065707c2dcbc
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 19, 2019
fa1d766 tests: Make msg_block a witness block (MarcoFalke) fa52eb5 test: Remove True argument to CBlock::serialize (MarcoFalke) Pull request description: Unnamed arguments are confusing as to what they mean without looking up the function signature. Since segwit is active by default in regtest, and all blocks are serialized with witness (bitcoin#15664), remove the argument `with_witness=True` from all calls to `CBlock::serialize` and `BlockTransactions::serialize`. ACKs for commit fa1d76: laanwj: code-review ACK fa1d766 Tree-SHA512: 2c550646f99c9ca86a223ca988c61a730f5e6646807adeaa7174fb2424a32cea3fef8bcd3e0b12e162e7ff192877d0c02fd0654df6ee1a9b821b065707c2dcbc
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 30, 2019
Unnamed arguments are confusing as to what they mean without looking up the function signature. Since segwit is active by default in regtest, and all blocks are serialized with witness (bitcoin#15664, c459c5f), remove the argument `with_witness=True` from all calls to `CBlock::serialize` and `BlockTransactions::serialize`. This diff has been created with a script, but is better reviewed without a scripted diff. sed -i --regexp-extended -e 's/block(_?[2a-z]*)\.serialize\([a-z_]*=?True/block\1.serialize(/g' $(git grep -l serialize ./test)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.