refactor: Remove unused function #15618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This should never have been merged in the first place, I'm happy this concerns an unused function but we should mark consensus-critical files at some point to prevent wallet and RPC PRs from affecting consensus-critical code accidentally. utACK fa5c511 |
Contributor
|
utACK fa5c511. |
Contributor
|
utACK fa5c511 |
laanwj
added a commit
that referenced
this pull request
Mar 18, 2019
fa5c511 refactor: Remove unused function (MarcoFalke) Pull request description: Oversight of kallewoof and mine in #13541 (comment) Tree-SHA512: 2fd3c4ecde5d3c58b113aa58d606976ceb4998358bde0547ead8e83df210722fa9821d2c88b717bdd190ef71593cd9c0154c3a5d3f2ccc3af8cbf6c36aaa6d45
Contributor
|
Post-merge utACK. Terribly sorry about that. I must've screwed up something between branches. I went through the merged code to make sure no other accidental code was included as well, and couldn't find any, FWIW. |
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Apr 22, 2019
Github-Pull: bitcoin#13541 Rebased-From: 6c0a6f7 Modifications: - Includes fix from bitcoin#15618 - Retains backward compatibility - Doesn't change all the unrelated tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight of kallewoof and mine in #13541 (comment)