[wallet-tool] Close bdb when flushing wallet #15390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Suggested by @MarcoFalke here: #13926 (comment) ping @promag |
1d079af to
d4d26d0
Compare
promag
reviewed
Feb 12, 2019
src/wallet/wallet.cpp
Outdated
Contributor
There was a problem hiding this comment.
This is not right, this will mess other dbs in the same env.
bdb would not be closed when closing the wallet in wallet-tool. Fix this by calling wallet->flush with true.
d4d26d0 to
318b1f7
Compare
Member
|
utACK 318b1f7 |
Member
|
Changed title prefix to |
Contributor
|
utACK 318b1f7 |
Contributor
|
Is there currently a strong reason to have the |
Member
|
@promag I don't think so, what would be the alternative? |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Feb 13, 2019
318b1f7 [wallet] Close bdb when flushing wallet. (John Newbery) Pull request description: bdb would not be closed when closing the wallet in wallet-tool. Fix this by calling wallet->flush with true. Tree-SHA512: f722e527e4806eca5254221e944f57853d11bf89a9264309fa558a6cc2b23feefb7bb2963e87b4fad9cfb31ac4cffe563688988e0614a481a8ff1d393aceb132
Contributor
Author
I don't believe so. It's a holdover from https://github.com/bitcoin/bitcoin/pull/10767/files |
Contributor
|
@jnewbery @MarcoFalke thanks, so I guess we all agree it can be cleaned up. utACK 318b1f7. |
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 3, 2020
Summary: [wallet] Close bdb when flushing wallet. (John Newbery) Pull request description: bdb would not be closed when closing the wallet in wallet-tool. Fix this by calling wallet->flush with true. --- Backport of Core [[bitcoin/bitcoin#15390 | PR15390]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7327
6293
pushed a commit
to 6293/dash
that referenced
this pull request
Nov 27, 2021
318b1f7 [wallet] Close bdb when flushing wallet. (John Newbery) Pull request description: bdb would not be closed when closing the wallet in wallet-tool. Fix this by calling wallet->flush with true. Tree-SHA512: f722e527e4806eca5254221e944f57853d11bf89a9264309fa558a6cc2b23feefb7bb2963e87b4fad9cfb31ac4cffe563688988e0614a481a8ff1d393aceb132
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bdb would not be closed when closing the wallet in wallet-tool. Fix this by calling wallet->flush with true.