doc: explain AcceptToMemoryPoolWorker's coins_to_uncache #15267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Jan 31, 2019
sdaftuar
suggested changes
Feb 21, 2019
Member
sdaftuar
left a comment
There was a problem hiding this comment.
Concept ACK, I'm all in favor of making stuff like this more understandable.
jnewbery
reviewed
Feb 22, 2019
Contributor
jnewbery
left a comment
There was a problem hiding this comment.
utACK 3ad03db4719ce5f949b2ebe359ef745b79e3db2e
3ad03db to
560caca
Compare
Contributor
Author
|
Thanks for the review. Pushed an update incorporating feedback. |
Contributor
|
Looks good to me! ACK 560cacacaea4ada97b29af83a5c4881108a2e80f |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Contributor
sdaftuar
reviewed
Mar 21, 2019
560caca to
5d26205
Compare
Member
|
Thanks for updating, utACK |
Contributor
|
ACK 5d26205 |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Apr 26, 2019
…_uncache 5d26205 doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (James O'Beirne) Pull request description: I found ATMPW's `coins_to_uncache` a little hard to understand (see bitcoin#15264). This adds some doc for posterity. ACKs for commit 5d2620: jnewbery: ACK 5d26205 Tree-SHA512: 088508fa78012fab8680663c4e30f5cee29768416c2ca8b8b2abc29b6ac7067c5a589674f0254474a7ccc95477889d41719760f5796792bf492f51b3dd499c6c
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jul 5, 2020
…ache Summary: bitcoin/bitcoin@5d26205 --- Backport of Core [[bitcoin/bitcoin#15267 | PR15267]] Test Plan: none Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6819
vijaydasmp
added a commit
to vijaydasmp/dash
that referenced
this pull request
Oct 20, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found ATMPW's
coins_to_uncachea little hard to understand (see #15264). This adds some doc for posterity.