tests: Possible fix the permission error when the tests open the cookie file #14788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Member
|
utACK 0cb4518d355738b2530a66cded2fc4b673ba1c2a |
Member
|
There's so much polling and waiting in the tests; from a determinism point of view I'd prefer to do this waiting once after starting a node, this is the only time where one'd expect the cookie to possibly not be there yet (maybe make it part of the current poll-after-run loop). (If the same happens and it's trying to find the cookie after shutdown this is a problem with the test and it shouldn't simply wait 10 seconds. Or if the cookie goes missing while a node is supposed to be running this is a problem with the software that should be detected immediately.) |
Contributor
Contributor
Author
|
@laanwj Now it would also raise ValueError if the cookie file is not readable. It can be caught in |
Member
|
utACK d6b3790 |
maflcko
pushed a commit
that referenced
this pull request
Dec 7, 2018
… open the cookie file d6b3790 tests: check readability of cookie file (Chun Kuan Lee) Pull request description: This PR would wait until the `.cookie` file is readable Possible fix no. 5 `PermissionError` in #14446 Tree-SHA512: e7055c7ca26a6eadbbe19e4eef08ffee61cd17de79b30af2f0d090f0ad81ca24815e3c7e034e5e30d47c580bb0b221b3955e9ff2fcec2274fbf7b9232ab0cdc7
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 11, 2021
…e tests open the cookie file d6b3790 tests: check readability of cookie file (Chun Kuan Lee) Pull request description: This PR would wait until the `.cookie` file is readable Possible fix no. 5 `PermissionError` in bitcoin#14446 Tree-SHA512: e7055c7ca26a6eadbbe19e4eef08ffee61cd17de79b30af2f0d090f0ad81ca24815e3c7e034e5e30d47c580bb0b221b3955e9ff2fcec2274fbf7b9232ab0cdc7
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Aug 15, 2021
…e tests open the cookie file d6b3790 tests: check readability of cookie file (Chun Kuan Lee) Pull request description: This PR would wait until the `.cookie` file is readable Possible fix no. 5 `PermissionError` in bitcoin#14446 Tree-SHA512: e7055c7ca26a6eadbbe19e4eef08ffee61cd17de79b30af2f0d090f0ad81ca24815e3c7e034e5e30d47c580bb0b221b3955e9ff2fcec2274fbf7b9232ab0cdc7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would wait until the
.cookiefile is readablePossible fix no. 5
PermissionErrorin #14446