Scripts: Fix detection of copyright holders #14785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
utACK 89104ef98f882c24695043b74feec2b9d0d8496f very nice change, the |
scravy
approved these changes
Nov 22, 2018
Contributor
Author
|
The failing test doesn't seem to be related to the code changes. It also does work locally. |
Member
|
utACK 89104ef98f882c24695043b74feec2b9d0d8496f |
Member
|
utACK 89104ef |
1 similar comment
Contributor
|
utACK 89104ef |
Member
|
utACK, but yes makes sense to address @practicalswift 's comment wrt overwriting internal functions. |
Contributor
|
utACK da9c379c4fafd5e39566a2014777513e87f5fb39 |
Member
|
utACK after squashing commits |
* There is a copyright notice in `src/crypto/sha256_sse4.cpp` in the middle of the file which contains a comma before the copyright holder name. Correctly detect this so it's added to the report. * Add missing copyright holders so that `copyright_header.py report` doesn't show any unexpected copyright holder names anymore. * Exclude files from git subtrees because they are maintained at the original source.
da9c379 to
af9a991
Compare
Contributor
Author
|
Squashed commits |
Member
|
Someone could probably bump the headers at this time of the year... |
maflcko
pushed a commit
that referenced
this pull request
Nov 23, 2018
af9a991 Fix detection of copyright holders (Cornelius Schumacher) Pull request description: Fix copyright holder detection so that `copyright_header.py report` creates a clean and accurate report: * Fix list of copyright holders in the code * Also detect copyrights which have a comma after the date * Exclude directories which are git subtrees Tree-SHA512: 7ab78618aa62c7d40b6688ddcde4a85c6fc5df8275271fa85518e146c1db90760bfafaa6036b9f6afbe887fd7e9274c913786101668573a3e289b3411aa6842f
cornelius
added a commit
to dtr-org/unit-e
that referenced
this pull request
Nov 27, 2018
Forward port of changes done in response to feedback on upstream pull request bitcoin/bitcoin#14785 Signed-off-by: Cornelius Schumacher <cornelius@thirdhash.com>
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 1, 2021
Summary: af9a9918b2 Fix detection of copyright holders (Cornelius Schumacher) Pull request description: Fix copyright holder detection so that `copyright_header.py report` creates a clean and accurate report: * Fix list of copyright holders in the code * Also detect copyrights which have a comma after the date * Exclude directories which are git subtrees --- Backport of Core [[bitcoin/bitcoin#14785 | PR14785]] Test Plan: run it, check results Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9114
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 11, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 13, 2021
merge bitcoin#14785, bitcoin#16314, bitcoin#17052: minor backports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix copyright holder detection so that
copyright_header.py reportcreates a clean and accurate report: