test_runner: Remove travis specific code #14630
Conversation
|
makes sense — concept ACK |
fa04a3a to
fadf976
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
fadf976 to
faf7770
Compare
|
Concept ACK. Why so many style-only changes in the same commit? |
|
Passing the value through touches a lot of function signatures and I run a python formatter on all changes I make before submitting a pull request. In the hope that no one can complain about my code style... |
|
A lot of it seems like your personal preference for style, and it inflates the diff substantially. For example, I don't think there's project guidelines about whether continuation lines of long function calls should be aligned to the opening parens or to some other indentation (both are fine under PEP8 https://www.python.org/dev/peps/pep-0008/#indentation). This seems like a +-5 line diff without the style changes. At the least, can you split the style changes into a separate commit so it's obvious what reviewers are supposed to be paying attention to? |
faf7770 to
fa43626
Compare
|
Removed the style change that affected lines that were in proximity to actually changed lines. |
|
utACK fa43626 |
fa43626 test_runner: Remove travis specific code (MarcoFalke) Pull request description: The tests are no longer run on travis, but in a docker, developer machines or a windows vm. The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm. Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
fa43626 test_runner: Remove travis specific code (MarcoFalke) Pull request description: The tests are no longer run on travis, but in a docker, developer machines or a windows vm. The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm. Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
fa43626 test_runner: Remove travis specific code (MarcoFalke) Pull request description: The tests are no longer run on travis, but in a docker, developer machines or a windows vm. The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm. Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
fa43626 test_runner: Remove travis specific code (MarcoFalke) Pull request description: The tests are no longer run on travis, but in a docker, developer machines or a windows vm. The code was essentially dead for months now. Fix that by explicitly passing in `--ci` to the test runner on our docker and appveyor windows vm. Tree-SHA512: 5d48693c03e8eb27536658ccf9ba738fe93a72abd4b72c80caac084b5b2cdffa77a1031a671eeefe70b71d63500f55917803d4be54d01849722afdccb700a9e6
The tests are no longer run on travis, but in a docker, developer machines or a windows vm.
The code was essentially dead for months now. Fix that by explicitly passing in
--cito the test runner on our docker and appveyor windows vm.