[tests] Test that nodes respond to getdata with notfound #14571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9a88c5 to
fa33a6b
Compare
Contributor
|
Concept ACK. Great test. |
jamesob
reviewed
Oct 25, 2018
Contributor
There was a problem hiding this comment.
nit: more concise (if not exactly equivalent) as self.vec = vec or []
Contributor
There was a problem hiding this comment.
I think Marco's version is clearer.
sanket1729
reviewed
Oct 25, 2018
test/functional/p2p_leak_tx.py
Outdated
Contributor
There was a problem hiding this comment.
I am new here, but is sync_all() necessary when there is only 1 node?
Contributor
There was a problem hiding this comment.
Entirely correct! This can be removed
fa33a6b to
fa57d64
Compare
Contributor
There was a problem hiding this comment.
This should be __slots__ = ("vec",) to force tuple instead of str :-)
Member
Author
There was a problem hiding this comment.
Ugh, I always get this wrong. Thx
If a node has not announced a tx at all, then it should respond to getdata messages for that tx with notfound, to avoid leaking tx origination privacy.
fa57d64 to
fa78a2f
Compare
Contributor
|
Tested ACK fa78a2f |
1 similar comment
Contributor
|
Tested ACK fa78a2f |
Contributor
|
Tested ACK fa78a2f |
maflcko
pushed a commit
that referenced
this pull request
Oct 27, 2018
fa78a2f [tests] Test that nodes respond to getdata with notfound (MarcoFalke) Pull request description: If a node has not announced a tx at all, then it should respond to getdata messages for that tx with notfound, to avoid leaking tx origination privacy. In the future this could be adjusted such that a node responds with notfound when a tx has not been announced to us, but that seems to be a more involved change. See e.g. https://github.com/jnewbery/bitcoin/commits/pr14220.1 Tree-SHA512: 6244afa5bd5d8fec9b89dfc02c9958bc370195145a0f3715f33200d6cf73a376c94193d44bf4523867196e6591c53ede8f9b6a77cb296b48c114a117b8c8b1fa
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jul 26, 2021
…notfound fa78a2f [tests] Test that nodes respond to getdata with notfound (MarcoFalke) Pull request description: If a node has not announced a tx at all, then it should respond to getdata messages for that tx with notfound, to avoid leaking tx origination privacy. In the future this could be adjusted such that a node responds with notfound when a tx has not been announced to us, but that seems to be a more involved change. See e.g. https://github.com/jnewbery/bitcoin/commits/pr14220.1 Tree-SHA512: 6244afa5bd5d8fec9b89dfc02c9958bc370195145a0f3715f33200d6cf73a376c94193d44bf4523867196e6591c53ede8f9b6a77cb296b48c114a117b8c8b1fa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a node has not announced a tx at all, then it should respond to
getdata messages for that tx with notfound, to avoid leaking tx
origination privacy.
In the future this could be adjusted such that a node responds with
notfound when a tx has not been announced to us, but that seems
to be a more involved change. See e.g.
https://github.com/jnewbery/bitcoin/commits/pr14220.1