Add Benchmark to test input de-duplication worst case #14400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Oct 5, 2018
Contributor
|
Concept ACK |
90b3b22 to
e1ed29f
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Oct 5, 2018
e1ed29f to
7bd1165
Compare
b9ee939 to
bb5baab
Compare
Contributor
Author
|
@MarcoFalke rebased, clang-formatted, etc. failure is unrelated to this PR now (one of the PBST tests) |
maflcko
approved these changes
Nov 25, 2018
Member
maflcko
left a comment
There was a problem hiding this comment.
Squash the fixup, so all commits compile?
bb5baab to
4a55f55
Compare
Fix nits replace utiltime?
4a55f55 to
e4eee7d
Compare
Contributor
Author
|
should be ready to merge now, pending integration tests. Thanks! |
Contributor
|
utACK e4eee7d
|
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Nov 25, 2018
… case e4eee7d Add Benchmark to test input de-duplication worst case (Jeremy Rubin) Pull request description: Because there are now 2PRs referencing this benchmark commit, we may as well add it independently as it is worth landing the benchmark even if neither patch is accepted. bitcoin#14397 bitcoin#14387 Tree-SHA512: 4d947323c02297b0d8f5871f9e7cc42488c0e1792a8b10dc174a25f4dd53da8146fd276949a5dbacf4083f0c6a7235cb6f21a8bc35caa499bc2508f8a048b987
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there are now 2PRs referencing this benchmark commit, we may as well add it independently as it is worth landing the benchmark even if neither patch is accepted.
#14397
#14387