Skip to content

Conversation

@priscoan
Copy link
Contributor

No description provided.

@fanquake fanquake added the Docs label Sep 25, 2018
@achow101
Copy link
Member

ACK f764fa661963df434847e217cadc3f07e2fba993

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 20, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14530 (Use RPCHelpMan to generate RPC doc strings by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

* Remove outdated reference to replaceable parameter
* Fix address reference
* Unify quotation and italicization of parameters
* Fix PSBT reference
@fanquake
Copy link
Member

@achow101 Did you want to re-ack here

@achow101
Copy link
Member

re-ACK 78542a3

@fanquake
Copy link
Member

utACK 78542a3

@laanwj laanwj merged commit 78542a3 into bitcoin:master Dec 13, 2018
laanwj added a commit that referenced this pull request Dec 13, 2018
78542a3 doc: Fix PSBT howto and example parameters (priscoan)

Pull request description:

Tree-SHA512: 2fcdd67717647e2f6166e6744c0938c96d8df6951e2ee5507372dad22ff66660f34c4554c86624c25f9a0dac2cdf8aff19bb7fc64a60e8e80a175f729ef913e4
@fanquake
Copy link
Member

Backported in #14945.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Dec 28, 2018
* Remove outdated reference to replaceable parameter
* Fix address reference
* Unify quotation and italicization of parameters
* Fix PSBT reference

Github-Pull: bitcoin#14319
Rebased-From: 78542a3
maflcko pushed a commit that referenced this pull request Dec 30, 2018
fa0c76a Fix minor grammar error in doc (bitcoinhodler)
88c566a doc: Fix PSBT howto and example parameters (priscoan)
ddd008d Add PSBT documentation (Pieter Wuille)

Pull request description:

  Backports #13941, #14319 and #15012 to 0.17.

Tree-SHA512: 9fbc900aa98f948260273970c4e51e69088460e153fd7dae8f3ddebf37c68ecdf1cd02f1f32759c638e5aecbb89529631e8cc7cad0e6370dbc21e70baa6e9145
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 5, 2020
Summary:
Backport of Core [[bitcoin/bitcoin#13941 | PR13941]], [[bitcoin/bitcoin#14319 | PR14319]] and [[bitcoin/bitcoin#15012 | PR15012]]
The second and third PR are minor fixes to the new documentation page created in the first PR.

Test Plan:
Tried out the procedure described in `Multisig with multiple Bitcoin ABC instances`
Made sure all the RPC commands listed in the doc actually exist.

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7758
linuxsh2 pushed a commit to linuxsh2/dash that referenced this pull request Aug 3, 2021
78542a3 doc: Fix PSBT howto and example parameters (priscoan)

Pull request description:

Tree-SHA512: 2fcdd67717647e2f6166e6744c0938c96d8df6951e2ee5507372dad22ff66660f34c4554c86624c25f9a0dac2cdf8aff19bb7fc64a60e8e80a175f729ef913e4
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants