[wallet] Remove addwitnessaddress #14296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Concept ACK |
Fix all flake8 warnings in tests that are about to be updated to remove addwitnessaddress
addwitnessaddress is deprecated. Replace the call to addwitnessaddress with a call to getnewaddress(address_type='p2sh-segwit')
addwitnessaddress is deprecated. Remove the call to that RPC from wallet_dump.py and improve testing of all types of address (legacy, p2sh-segwit and bech32)
e70b870 to
850908a
Compare
Contributor
Author
|
Travis was failing because of new flake8 warnings. I've added a new commit removing all flake8 warnings from touched tests. |
Contributor
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
promag
reviewed
Oct 2, 2018
doc/release-notes-14296.md
Outdated
Contributor
There was a problem hiding this comment.
From doc/release-notes/release-notes-0.13.0.md
- New RPC commands:
generatetoaddress,importprunedfunds,removeprunedfunds,signmessagewithprivkey,
getmempoolancestors,getmempooldescendants,getmempoolentry,
createwitnessaddress,addwitnessaddress.
doc/release-notes-14296.md
Outdated
Contributor
There was a problem hiding this comment.
From doc/release-notes/release-notes-0.16.0.md
- The wallet RPC
addwitnessaddresswas deprecated and will be removed in version 0.17,
850908a to
2b91e42
Compare
Contributor
Author
|
Thanks for the corrections @promag . I've fixed them both. |
Member
|
utACK 2b91e42 |
Contributor
|
Tested ACK 2b91e42, only change was fixing release notes. |
This was referenced Oct 20, 2018
Closed
maflcko
pushed a commit
that referenced
this pull request
Oct 24, 2018
2b91e42 [docs] Add release note for removing getwitnessaddress (John Newbery) ebec90a [wallet] Remove deprecated addwitnessaddress RPC method (John Newbery) 07e3f58 [test] Remove deprecated addwitnessaddress from feature_segwit.py (John Newbery) 82f2fa0 [test] Remove deprecated addwitnessaddress from wallet_bumpfee.py (John Newbery) 9d7ee18 [test] Remove deprecated addwitnessaddress from p2p_compactblocks.py (John Newbery) 3cf77f0 [tests] Remove deprecated addwitnessaddress call from wallet_dump.py (John Newbery) bdefc97 [tests] Remove deprecated addwitnessaddress call from feature_nulldummy (John Newbery) 67d7d67 [test] Fix flake8 warnings in tests (John Newbery) Pull request description: Fully removes the `addwitnessaddress` RPC method, which was deprecated in V0.17 Tree-SHA512: 8fa8a2a721a81262fbdedbe1cef031e6a07aa6abbc9760dbc62738fc4f688b44bd737d0f3cdb1aec046866a6395befbfecde0f34e76a99e11d3cf566cad1d0de
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully removes the
addwitnessaddressRPC method, which was deprecated in V0.17