doc: Split depends installation instructions per arch #14264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Fun fact: |
Contributor
| No more conflicts as of last run. |
c18f9da to
77774f1
Compare
501f52e to
30c7c10
Compare
Member
Author
|
Tested that the current instructions work on no fresh and minimal ubuntu/debian due to missing packages or not-found packages. |
facf72a to
fad16ac
Compare
Member
Author
|
Tested that depends compilation (and cross-compilation) works now with fad16ac14df1190de4c9fa9ee2e5ae89c421f0d3 on debian:9, xenial and bionic. |
arowser
reviewed
Sep 19, 2018
depends/README.md
Outdated
Contributor
There was a problem hiding this comment.
line 51 is for aarch64, I guess you should swap with line 55.
faf5355 to
fa6e22e
Compare
depends/README.md
Outdated
Contributor
There was a problem hiding this comment.
2018-09-19 20:32:54 mdl(pr=14264): depends/README.md:39: MD026 Trailing punctuation in header
depends/README.md
Outdated
Contributor
There was a problem hiding this comment.
2018-09-19 20:32:54 mdl(pr=14264): depends/README.md:43: MD026 Trailing punctuation in header
depends/README.md
Outdated
Contributor
There was a problem hiding this comment.
2018-09-19 20:32:54 mdl(pr=14264): depends/README.md:47: MD026 Trailing punctuation in header
09056d2 to
fad95e8
Compare
Contributor
|
Member
Author
|
@Sjors I've stolen this from you. Mind to take a look here if it looks right? |
Member
|
It looks OK to me, but only way to know for sure is to try on a fresh machine, which I haven't gotten around to. |
Member
Author
|
I am going to merge, since the current instructions are broken and I tried this on several fresh machines. |
maflcko
pushed a commit
that referenced
this pull request
Oct 4, 2018
fad95e8 doc: Split build linux dependencies (MarcoFalke) 0000009 doc: Split depends installation instructions per arch (MarcoFalke) Pull request description: The current depends installation instructions fail on bionic with ``` E: Unable to locate package g++-4.8-aarch64-linux-gnu E: Unable to locate package gcc-4.8-aarch64-linux-gnu E: Unable to locate package g++-4.8-arm-linux-gnueabihf E: Unable to locate package gcc-4.8-arm-linux-gnueabihf ``` Also, they fail due to missing dependencies `make automake cmake pkg-config python3` Fix this by removing the explicit version and splitting them into common instructions and instructions per linux architecture. Tree-SHA512: 25d5efa7450a0b1bbd569f431158f5a25bf4fe34f6adc32ebdfd6b6db9447ce083f555f20ff5b9f7c458864986c15d65219a31a1cd2b18bad9965ece2ea5e3be
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 6, 2020
Summary: This diff updates the cross compilation instructions to use cmake and ninja. It also make the doc in sync with core with up to date dependencies. Backport of core [[bitcoin/bitcoin#14264 | PR14264]] and [[bitcoin/bitcoin#16051 | PR16051]]. Test Plan: Read and test the instructions. Reviewers: #bitcoin_abc, jasonbcox, deadalnix Reviewed By: #bitcoin_abc, jasonbcox, deadalnix Subscribers: jasonbcox, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5394
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Aug 17, 2020
Summary: This diff updates the cross compilation instructions to use cmake and ninja. It also make the doc in sync with core with up to date dependencies. Backport of core [[bitcoin/bitcoin#14264 | PR14264]] and [[bitcoin/bitcoin#16051 | PR16051]]. Test Plan: Read and test the instructions. Reviewers: #bitcoin_abc, jasonbcox, deadalnix Reviewed By: #bitcoin_abc, jasonbcox, deadalnix Subscribers: jasonbcox, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D5394
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current depends installation instructions fail on bionic with
Also, they fail due to missing dependencies
make automake cmake pkg-config python3Fix this by removing the explicit version and splitting them into common instructions and instructions per linux architecture.