wallet: Catch filesystem_error and raise InitError #13876
Conversation
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Before: After:
Using:
|
|
certainly better |
|
Gitian builds for commit 2b67354 (master):
Gitian builds for commit 04cb409e2c353fce1e6b02e08ae7e94c03b53185 (master and this pull):
|
|
Adding to 0.17.0 milestone as I think this is a regression? |
|
Regression in a sense that it throws a useless error as opposed to something more helpful. |
|
Ideally we'd handle runtime errors more sanely and automatic as opposed to splattered catch clauses all over the place. Imo we should provide a copy-paste able stacktrace on runtime errors and a link to submit an issue with all the debugging information attached. |
|
@Sjors Mind to take a quick look at the patch, please? |
|
For some reason this build throws an unexpected error for me, even when launching without
|
|
I just tried again and they work for me with a fresh account:
|
|
@MarcoFalke I downloaded it (and master) straight from @DrahtBot and the link you posted (only your version). It's weird, but given that my error is created elsewhere in the code, and others don't see it, maybe just ignore? |
|
Tested ACK fa8527f Although the message is a mess if the system setting is not English.
|
Summary: Fixes #13754 by restoring the previous behaviour Backport of Bitcoin Core PR13876 bitcoin/bitcoin#13876 Test Plan: ``` make check ``` Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D3987
fa8527f wallet: Catch filesystem_error and raise InitError (MarcoFalke) Pull request description: Fixes bitcoin#13754 by restoring the previous behaviour Tree-SHA512: f64052e89f6b332be395df2a5ea6f227c213fa2f38e415e83f30a4fad0938e947e5cddff7902368a43c07be135955a31b90f7eac5a46875c58d54ea95f87f6e6
Fixes #13754 by restoring the previous behaviour