Skip to content

travis: Check that ~/.bitcoin is never created #13687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 2 commits into from
Jul 18, 2018
Merged

travis: Check that ~/.bitcoin is never created #13687

laanwj merged 2 commits into from
Jul 18, 2018

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Jul 17, 2018

No description provided.

@laanwj
Copy link
Member

laanwj commented Jul 17, 2018

Nice. For some reason I thought we already had this. Concept ACK.

@maflcko
Copy link
Member Author

maflcko commented Jul 17, 2018

Travis failure:

  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/feature_config_args.py", line 39, in run_test

    self.nodes[0].assert_start_raises_init_error(['-conf=' + conf_file], 'Error reading configuration file: specified data directory "' + new_data_dir + '" does not exist.')

  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 266, in assert_start_raises_init_error

    'Expected message "{}" does not fully match stderr:\n"{}"'.format(expected_msg, stderr))

  File "/home/travis/build/bitcoin/bitcoin/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_node.py", line 108, in _raise_assertion_error

    raise AssertionError(self._node_msg(msg))

AssertionError: [node 0] Expected message "Error reading configuration file: specified data directory "/tmp/bitcoin_test_runner_20180717_122100/feature_config_args_1/node0/newdatadir" does not exist." does not fully match stderr:

"************************

EXCEPTION: N5boost10filesystem16filesystem_errorE       

boost::filesystem::create_directory: File exists: "/root/.bitcoin"       

bitcoin in AppInit()

@maflcko
Copy link
Member Author

maflcko commented Jul 17, 2018

I have no idea how to fix the broken functional test cross platform without removing it.

Closing as "up for grabs".

@maflcko maflcko closed this Jul 17, 2018
@maflcko maflcko deleted the Mf1709-travisHomeDirBtc branch July 17, 2018 12:35
@laanwj
Copy link
Member

laanwj commented Jul 17, 2018

Let's remove it then. I prefer having this test, TBH.

@maflcko maflcko restored the Mf1709-travisHomeDirBtc branch July 17, 2018 12:59
@maflcko maflcko reopened this Jul 17, 2018
@maflcko maflcko added this to the 0.17.0 milestone Jul 17, 2018
@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 17, 2018

Note to reviewers: This pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Jul 17, 2018
Closed
@maflcko maflcko force-pushed the Mf1709-travisHomeDirBtc branch from fa0aa7c to fabe28a Compare July 17, 2018 17:39
@maflcko maflcko removed this from the 0.17.0 milestone Jul 17, 2018
@laanwj
Copy link
Member

laanwj commented Jul 17, 2018

utACK fabe28a

@laanwj laanwj merged commit fabe28a into bitcoin:master Jul 18, 2018
laanwj added a commit that referenced this pull request Jul 18, 2018
@laanwj
Merge #13687: travis: Check that ~/.bitcoin is never created
9d26b69 
fabe28a qa: Temporarily disable test that reads the default datadir location (MarcoFalke)
41a8c8d travis: Check that ~/.bitcoin is never created (MarcoFalke)

Pull request description:

Tree-SHA512: d114db29a18f684d207caa0d7c947b13c945e2dd8b6d7fdeacdf7aa194f8123579d1139331b9d308df69a1132796e805a9ab63580aebde9b719860c0ff4b5652
@maflcko maflcko deleted the Mf1709-travisHomeDirBtc branch July 18, 2018 14:34
@Bushstar Bushstar mentioned this pull request Jul 19, 2018
Merged
@maflcko maflcko mentioned this pull request Apr 9, 2020
Merged
maflcko pushed a commit that referenced this pull request Apr 22, 2020
Merge #18575: bench: Remove requirement that all benches use same tes…
a7a6f1f 
…ting setup

fa1fdb0 bench: Replace ::mempool globabl with test_setup.mempool (MarcoFalke)
fab1170 bench: Remove requirement that all benches use RegTestingSetup (MarcoFalke)

Pull request description:

  The benches have always set up one global testing setup. This makes it hard to pick no testing setup at all or one with different params.

  Fix this by removing any global state setup from the main `bench.cpp` and leave the setup to each individual bench.

  One reason to have one global testing setup is to set the datadir location to a tempdir to avoid reading or writing in the default datadir location. But #13687 should prevent this already.

Top commit has no ACKs.

Tree-SHA512: 7c98aea7725a20f4b9225221f4279b9e9f7257ed5c14712ad01ea80d87c3b0fed760b40f413892498bbb354a917ee02d4c575cbe8423a403b86755e8ee11f33b
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 23, 2020
Merge bitcoin#18575: bench: Remove requirement that all benches use s…
be86c36 
…ame testing setup

fa1fdb0 bench: Replace ::mempool globabl with test_setup.mempool (MarcoFalke)
fab1170 bench: Remove requirement that all benches use RegTestingSetup (MarcoFalke)

Pull request description:

  The benches have always set up one global testing setup. This makes it hard to pick no testing setup at all or one with different params.

  Fix this by removing any global state setup from the main `bench.cpp` and leave the setup to each individual bench.

  One reason to have one global testing setup is to set the datadir location to a tempdir to avoid reading or writing in the default datadir location. But bitcoin#13687 should prevent this already.

Top commit has no ACKs.

Tree-SHA512: 7c98aea7725a20f4b9225221f4279b9e9f7257ed5c14712ad01ea80d87c3b0fed760b40f413892498bbb354a917ee02d4c575cbe8423a403b86755e8ee11f33b
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maflcko @laanwj @DrahtBot