Skip to content

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Jun 21, 2018

From 3.6.0 onwards, Protobuf requires C++11. See discussion in protocolbuffers/protobuf#2780.
This updates depends to that release, and swaps to the cpp specific download.

TODO:

  • Do we still need to explicitly pass -std=c++11 to cxxflags in our protobuf package?
  • Needs more testing/depends builds done on platforms other than macOS.

Protobuf 3.6.1 (C++) release notes:

  • Introduced workaround for Windows issue with std::atomic and std::once_flag
    initialization.

Protobuf 3.6.0 (C++) release notes:

  • Starting from this release, we now require C++11. For those we cannot yet upgrade to C++11, we will try to keep the 3.5.x branch updated with critical bug fixes only. If you have any concerns about this, please comment on issue error: {"code":-1,"message":"ReserveKeyFromKeyPool() : unknown key in key pool"} - After importprivkey #2780.
  • Moved to C++11 types like std::atomic and std::unique_ptr and away from our old custom-built equivalents.
  • Added support for repeated message fields in lite protos using implicit weak fields. This is an experimental feature that allows the linker to strip out more unused messages than previously was possible.
  • Fixed SourceCodeInfo for interpreted options and extension range options.
  • Fixed always_print_enums_as_ints option for JSON serialization.
  • Added support for ignoring unknown enum values when parsing JSON.
  • Create std::string in Arena memory.
  • Fixed ValidateDateTime to correctly check the day.
  • Fixed bug in ZeroCopyStreamByteSink.
  • Various other cleanups and fixes.

@fanquake fanquake requested a review from theuni June 21, 2018 02:34
@maflcko
Copy link
Member

maflcko commented Jun 21, 2018

What would be the main advantage of this bump?

@fanquake fanquake force-pushed the depends-protobuf-36 branch from 4fd67b1 to 9ecce97 Compare August 2, 2018 13:49
@fanquake fanquake changed the title [wip] depends: native_protobuf 3.6.0 [wip] depends: native_protobuf 3.6.1 Aug 2, 2018
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 2, 2018

No more conflicts as of last run.

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 6, 2018

Needs rebase

@fanquake fanquake force-pushed the depends-protobuf-36 branch from 8686e3b to 07688b4 Compare August 17, 2018 03:53
@fanquake
Copy link
Member Author

fanquake commented Oct 9, 2018

Closing, going to wrap this up in some more extensive depends work.

@fanquake fanquake closed this Oct 9, 2018
@fanquake fanquake removed the request for review from theuni October 9, 2018 05:30
maflcko pushed a commit that referenced this pull request Oct 26, 2018
3387bb0 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee)

Pull request description:

  - If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build.
  - Enable Qt build for Windows and 32-bit Linux
  - Enable wallet for depends x86-64 Linux
  - Disable gui tests for Windows since they are not supported

  This would be helpful for upgrading Qt (#12971) and protobuf (#13513)

Tree-SHA512: e943cbd848d90f9f70e29c94ed717f96ad2c2d27b433bafea762015756a2d2794fc28976c54aee087bf0f3726ac2c9140920272445a902038719b956e2160cf9
@fanquake fanquake deleted the depends-protobuf-36 branch January 22, 2020 11:29
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jul 21, 2021
3387bb0 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee)

Pull request description:

  - If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build.
  - Enable Qt build for Windows and 32-bit Linux
  - Enable wallet for depends x86-64 Linux
  - Disable gui tests for Windows since they are not supported

  This would be helpful for upgrading Qt (bitcoin#12971) and protobuf (bitcoin#13513)

Tree-SHA512: e943cbd848d90f9f70e29c94ed717f96ad2c2d27b433bafea762015756a2d2794fc28976c54aee087bf0f3726ac2c9140920272445a902038719b956e2160cf9
Munkybooty pushed a commit to Munkybooty/dash that referenced this pull request Jul 23, 2021
3387bb0 travis: avoid timeout without saving caches, also enable all qt (Chun Kuan Lee)

Pull request description:

  - If depends build take more than 20 mins, skip Bitcoin Core build to store depends caches and mark it fail. Then restart the job for Bitcoin Core build.
  - Enable Qt build for Windows and 32-bit Linux
  - Enable wallet for depends x86-64 Linux
  - Disable gui tests for Windows since they are not supported

  This would be helpful for upgrading Qt (bitcoin#12971) and protobuf (bitcoin#13513)

Tree-SHA512: e943cbd848d90f9f70e29c94ed717f96ad2c2d27b433bafea762015756a2d2794fc28976c54aee087bf0f3726ac2c9140920272445a902038719b956e2160cf9
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants