GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default #13251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- "Bech32" isn't very user-friendly - You don't spend from addresses
Member
Author
Contributor
|
utACK 82dda6b |
1 similar comment
Member
|
utACK 82dda6b |
maflcko
pushed a commit
that referenced
this pull request
May 17, 2018
… legacy address default 82dda6b GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr) 7ab1c6f GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr) Pull request description: - "Bech32" isn't very user-friendly; used "native segwit" as in #11937. - You don't spend from addresses. - No reason to block off Bech32 access with legacy address default. Rebased from #12208 Tree-SHA512: c82dd20d967a7f47bcc75b25be0d3a8cf00cfccc1cd14916b87d70b9c56fd53e366b456348b173f36c89b145b76624413780abaed4cea82117a9ecd47dd8fb99
Contributor
|
utACK 82dda6b. |
Contributor
|
I think a better tooltip would be "Native segwit addresses (Bech32) reduce your transaction fees later on and offer better protection against typos, but are unsupported by old wallets. When unchecked, an address compatible with older wallets will be created instead." But otherwise utACK 82dda6b |
Contributor
|
Post Merge utACK 82dda6b |
Member
|
Thanks. Sorry I've fallen so far behind on rebases. :( |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 24, 2018
- "Bech32" isn't very user-friendly - You don't spend from addresses Github-Pull: bitcoin#13251 Rebased-From: 7ab1c6f
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 24, 2018
Github-Pull: bitcoin#13251 Rebased-From: 82dda6b
Member
Author
|
Backported in #13319 |
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jun 29, 2018
- "Bech32" isn't very user-friendly - You don't spend from addresses Github-Pull: bitcoin#13251 Rebased-From: 7ab1c6f
HashUnlimited
pushed a commit
to chaincoin/chaincoin
that referenced
this pull request
Jun 29, 2018
Github-Pull: bitcoin#13251 Rebased-From: 82dda6b
TheArbitrator
pushed a commit
to TheArbitrator/dash
that referenced
this pull request
Jun 21, 2021
…it with legacy address default 82dda6b GUI: Allow generating Bech32 addresses with a legacy-address default (Luke Dashjr) 7ab1c6f GUI: Rephrase Bech32 checkbox text/tooltip (Luke Dashjr) Pull request description: - "Bech32" isn't very user-friendly; used "native segwit" as in bitcoin#11937. - You don't spend from addresses. - No reason to block off Bech32 access with legacy address default. Rebased from bitcoin#12208 Tree-SHA512: c82dd20d967a7f47bcc75b25be0d3a8cf00cfccc1cd14916b87d70b9c56fd53e366b456348b173f36c89b145b76624413780abaed4cea82117a9ecd47dd8fb99
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased from #12208