doc: Add note about our preference for scoped enumerations ("enum class") #12800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5ea287 to
5cb262b
Compare
maflcko
reviewed
Mar 27, 2018
doc/developer-notes.md
Outdated
Member
There was a problem hiding this comment.
I had the impression it was possible to specify the type even for the "deprecated" enum.
Contributor
Author
There was a problem hiding this comment.
@MarcoFalke Ah, you're right. Forward declaration of enum:s was fixed in C++11. Will update!
Member
There was a problem hiding this comment.
It's ok, avoiding scope leak is the best argument for using scoped enums anyway.
5cb262b to
0fee2b4
Compare
Member
|
ACK 0fee2b4 |
laanwj
added a commit
that referenced
this pull request
Mar 27, 2018
…ons ("enum class")
0fee2b4 doc: Add note about our preference for scoped enumerations ("enum class") (practicalswift)
Pull request description:
Add note about our preference for scoped enumerations (`enum class`).
Context: #10742
Tree-SHA512: 0ab3465c2b734240cb38a05c2f6e75f1af54207a0f1a2e8115e7b367fd37e8966a2fc0240c6d4c2c66b6677b5f367eda4f4b783bbaa419777336c17f04adff06
Member
|
utACK 0fee2b4 |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 17, 2020
…umerations ("enum class")
0fee2b4 doc: Add note about our preference for scoped enumerations ("enum class") (practicalswift)
Pull request description:
Add note about our preference for scoped enumerations (`enum class`).
Context: bitcoin#10742
Tree-SHA512: 0ab3465c2b734240cb38a05c2f6e75f1af54207a0f1a2e8115e7b367fd37e8966a2fc0240c6d4c2c66b6677b5f367eda4f4b783bbaa419777336c17f04adff06
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add note about our preference for scoped enumerations (
enum class).Context: #10742