Fix bug in memory usage calculation (unintended integer division) #12784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ACK 490e8be. |
laanwj
reviewed
Mar 27, 2018
src/dbwrapper.cpp
Outdated
Member
There was a problem hiding this comment.
Wouldn't replacing 1024 with 1024.0 here (and in the other case) have the same effect, but avoid the cast?
Contributor
Author
There was a problem hiding this comment.
@laanwj Absolutely! Now updated. Please re-review :-)
490e8be to
a16c6d2
Compare
Contributor
|
ACK a16c6d2 I'm really tempted to add formatters for MiB and whatnot as a new format specifier in |
Member
|
utACK a16c6d2 |
eklitzke
approved these changes
Mar 28, 2018
Contributor
Author
|
@eklitzke Formatters for MiB, etc sounds nice! |
Member
|
utACK a16c6d2 |
Member
I'd prefer not to make such changes to tinyformat.h locally. Unless you manage to upstream it (https://github.com/c42f/tinyformat), an utility function would be preferable. Although this is arguably so simple I'm not sure how much is gained by that. |
laanwj
added a commit
that referenced
this pull request
Mar 29, 2018
… division) a16c6d2 Fix error in memory usage calculation (unintended integer division) (practicalswift) Pull request description: Fix bug in memory usage calculation (unintended integer division). Tree-SHA512: 2df1f00c5282581c61e1fd55fef3fabc02161b5a47d8f1795b05d57117245ff3d1ee861dd689eebe0185f28176cea428007e799d5c43a1ce5dc704123439f967
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 30, 2019
Summary: Backport of Bitcoin Core PR12604 and PR12784 bitcoin/bitcoin#12604 bitcoin/bitcoin#12784 Test Plan: ``` make check ``` Run `bitcoind` with `-debug=leveldb` and check the log file for the `LEVELDB` category and the following pattern: `WriteBatch memory usage: db=..., before=...MiB, after=...MiB` Verify that printed sizes (before and after) make sense. Reviewers: Fabien, O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3948
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Dec 8, 2019
Summary: Backport of Bitcoin Core PR12604 and PR12784 bitcoin/bitcoin#12604 bitcoin/bitcoin#12784 Test Plan: ``` make check ``` Run `bitcoind` with `-debug=leveldb` and check the log file for the `LEVELDB` category and the following pattern: `WriteBatch memory usage: db=..., before=...MiB, after=...MiB` Verify that printed sizes (before and after) make sense. Reviewers: Fabien, O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3948
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Dec 8, 2019
Summary: Backport of Bitcoin Core PR12604 and PR12784 bitcoin/bitcoin#12604 bitcoin/bitcoin#12784 Test Plan: ``` make check ``` Run `bitcoind` with `-debug=leveldb` and check the log file for the `LEVELDB` category and the following pattern: `WriteBatch memory usage: db=..., before=...MiB, after=...MiB` Verify that printed sizes (before and after) make sense. Reviewers: Fabien, O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3948
jonspock
pushed a commit
to jonspock/devault
that referenced
this pull request
Dec 8, 2019
Summary: Backport of Bitcoin Core PR12604 and PR12784 bitcoin/bitcoin#12604 bitcoin/bitcoin#12784 Test Plan: ``` make check ``` Run `bitcoind` with `-debug=leveldb` and check the log file for the `LEVELDB` category and the following pattern: `WriteBatch memory usage: db=..., before=...MiB, after=...MiB` Verify that printed sizes (before and after) make sense. Reviewers: Fabien, O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3948
proteanx
pushed a commit
to devaultcrypto/devault
that referenced
this pull request
Dec 12, 2019
Summary: Backport of Bitcoin Core PR12604 and PR12784 bitcoin/bitcoin#12604 bitcoin/bitcoin#12784 Test Plan: ``` make check ``` Run `bitcoind` with `-debug=leveldb` and check the log file for the `LEVELDB` category and the following pattern: `WriteBatch memory usage: db=..., before=...MiB, after=...MiB` Verify that printed sizes (before and after) make sense. Reviewers: Fabien, O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D3948
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 14, 2020
…integer division) a16c6d2 Fix error in memory usage calculation (unintended integer division) (practicalswift) Pull request description: Fix bug in memory usage calculation (unintended integer division). Tree-SHA512: 2df1f00c5282581c61e1fd55fef3fabc02161b5a47d8f1795b05d57117245ff3d1ee861dd689eebe0185f28176cea428007e799d5c43a1ce5dc704123439f967
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 24, 2021
…integer division) a16c6d2 Fix error in memory usage calculation (unintended integer division) (practicalswift) Pull request description: Fix bug in memory usage calculation (unintended integer division). Tree-SHA512: 2df1f00c5282581c61e1fd55fef3fabc02161b5a47d8f1795b05d57117245ff3d1ee861dd689eebe0185f28176cea428007e799d5c43a1ce5dc704123439f967
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jan 29, 2022
…integer division) a16c6d2 Fix error in memory usage calculation (unintended integer division) (practicalswift) Pull request description: Fix bug in memory usage calculation (unintended integer division). Tree-SHA512: 2df1f00c5282581c61e1fd55fef3fabc02161b5a47d8f1795b05d57117245ff3d1ee861dd689eebe0185f28176cea428007e799d5c43a1ce5dc704123439f967
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug in memory usage calculation (unintended integer division).